Handle string callable in case of non-static method

[Jean85]

This is an improvement over #815. Thanks to @dmitry-pro for spotting the bug to start with.

[Jean85]

Umh, there's something strange... I cannot reproduce the bug outside of Sentry's tests: https://3v4l.org/1CEnC

What's really triggering the issue in here?

[dmytro-pro]

@Jean85 don't have much time for testing, but it is
https://3v4l.org/XMiVr
Strange that it doesn't trigger in Your (previous) example - when I caught this error, it was found in public dynamic method, not function.
I'll test it more when I free.

[Jean85]

I've found the difference: the issue is present with functions, not with class methods: https://3v4l.org/4ibt7

Not sure why there's a difference, the bug seems to be very subtle.

[EDIT] I have found the root cause, and it's not a bug: https://bugs.php.net/bug.php?id=61467#1332546423

As explained by Rasmus himself, the point is that the callable type has to trigger the autoloader and invoke it to check if it's an actual callable or a simple string, so that deprecation is unavoidable.

[ste93cry]

Unfortunately we cannot remove the typehint or we will have a BC

[Jean85]

Unfortunately we cannot remove the typehint or we will have a BC

Crap that's true... maybe we can hotfix it in the previous method, but it would still be broken for other usages

[chekalsky]

@Jean85 When are you planning to release it? Pretty annoying bug :-)

[ste93cry]

Would you be so kind to fix the remaining issues and rebase the PR on top of the master branch? Also does the test in AbstractSerializerTest covers this issue?

[emircanerkul]

Hi @ste93cry @Jean85

I face the same issue now while using sentry/sentry 3.22.1.

Is there any regression?

Deprecated: Use of "static" in callables is deprecated in /app/vendor/sentry/sentry/src/Serializer/AbstractSerializer.php on line 265 Deprecated: Use of "static" in callables is deprecated in /app/vendor/sentry/sentry/src/Serializer/AbstractSerializer.php on line 265 Deprecated: Use of "static" in callables is deprecated in /app/vendor/sentry/sentry/src/Serializer/AbstractSerializer.php on line 265 Deprecated: Use of "static" in callables is deprecated in /app/vendor/sentry/sentry/src/Serializer/AbstractSerializer.php on line 265 Deprecated: Use of "static" in callables is deprecated in /app/vendor/sentry/sentry/src/Serializer/AbstractSerializer.php on line 265 Deprecated: Use of "static" in callables is deprecated in /app/vendor/sentry/sentry/src/Serializer/AbstractSerializer.php on line 265

[ste93cry]

It may be, even though it's the first time it is reported since years... I suggest to try version 4.x of the SDK, and if the issue persist open a new issue.