Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SDK metapackage #190

Merged
merged 2 commits into from
Feb 25, 2019
Merged

Use SDK metapackage #190

merged 2 commits into from
Feb 25, 2019

Conversation

Jean85
Copy link
Contributor

@Jean85 Jean85 commented Feb 25, 2019 •
edited
Loading

WIP: this includes/targets #184, do not merge before that one.

Ok master is now 3.x, this is ready to be merged.

@Jean85 Jean85 added this to the 3.0 (Sentry client 2.0) milestone Feb 25, 2019
@Jean85 Jean85 self-assigned this Feb 25, 2019
@Jean85 Jean85 mentioned this pull request Feb 25, 2019
Merged
@Jean85 Jean85 changed the title Use SDK metapackage [WIP] Use SDK metapackage Feb 25, 2019
@Jean85 Jean85 closed this Feb 25, 2019
@Jean85 Jean85 mentioned this pull request Feb 25, 2019
Closed
@Jean85 Jean85 changed the base branch from 3.0 to master February 25, 2019 16:34
@Jean85 Jean85 changed the title [WIP] Use SDK metapackage Use SDK metapackage Feb 25, 2019
@Jean85 Jean85 reopened this Feb 25, 2019
stayallive
stayallive approved these changes Feb 25, 2019
View reviewed changes
Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Jean85 Jean85 mentioned this pull request Feb 25, 2019
Merged
@Jean85 Jean85 merged commit e377ccb into master Feb 25, 2019
@Jean85 Jean85 deleted the use-sdk-metapackage branch February 25, 2019 17:34
This was referenced Feb 25, 2019
Closed
Closed
@garak garak mentioned this pull request Sep 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stayallive stayallive stayallive approved these changes

Assignees

@Jean85 Jean85

Labels
None yet
Projects
None yet
Milestone
3.0 (Sentry client 2.0)
Development

Successfully merging this pull request may close these issues.
2 participants
@Jean85 @stayallive