Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http proxy option #192

Merged
merged 2 commits into from
Feb 25, 2019
Merged

Add http proxy option #192

merged 2 commits into from
Feb 25, 2019

Conversation

Jean85
Copy link
Contributor

@Jean85 Jean85 commented Feb 25, 2019

This includes #190, do not merge before it.

This maps the http_proxy option, which was restored in getsentry/sentry-php#775

@Jean85 Jean85 added this to the 3.0 (Sentry client 2.0) milestone Feb 25, 2019
@Jean85 Jean85 self-assigned this Feb 25, 2019
@Jean85 Jean85 force-pushed the add-http-proxy-option branch from f7b88e2 to 9422e53 Compare February 25, 2019 17:35
@Jean85 Jean85 marked this pull request as ready for review February 25, 2019 17:35
@Jean85 Jean85 requested a review from stayallive February 25, 2019 17:35
Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@Jean85 Jean85 merged commit 108e738 into master Feb 25, 2019
@Jean85 Jean85 deleted the add-http-proxy-option branch February 25, 2019 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants