Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile Replay] Issue Detail Tab: Incorrect number of Users #74751

Closed
Tracked by #74441
bruno-garcia opened this issue Jul 23, 2024 · 5 comments · Fixed by #75023
Closed
Tracked by #74441

[Mobile Replay] Issue Detail Tab: Incorrect number of Users #74751

bruno-garcia opened this issue Jul 23, 2024 · 5 comments · Fixed by #75023
Assignees

Comments

@bruno-garcia
Copy link
Member

The different users here are defined by the user.id, and there are 2 different users, but the app says 5:

Image

Example: https://sentry-sdks.sentry.io/issues/5607602092/replays/?project=4507596011798528&query=is%3Aunresolved+issue.priority%3A%5Bhigh%2C+medium%5D&referrer=issue-stream&selected_replay_index=0&statsPeriod=30d&stream_index=0

Relates to:

@getsantry
Copy link
Contributor

getsantry bot commented Jul 23, 2024

Routing to @getsentry/product-owners-replays for triage ⏲️

@c298lee
Copy link
Member

c298lee commented Jul 24, 2024

@bruno-garcia the underlying code is actually only counting the number of replays, not the users. Do we want to modify the message to say the "number of replays", or do we want to add a new hook that actually counts the number of users?

@jas-kas
Copy link
Member

jas-kas commented Jul 24, 2024

@c298lee users if possible, depending on complexity. i think that's more of an interesting insight than pure replay count (that count is already there on the Replay tab :/)

@c298lee
Copy link
Member

c298lee commented Jul 25, 2024

@jas-kas implementing a user count would be a little complex since we will need backend support to write a new query. Our replay count endpoint currently only returns the count and no user info so it would need to be modified for this case. I think we should just modify the text for this case, wdyt?

c298lee added a commit that referenced this issue Jul 26, 2024
We are getting a replay count instead of a user count, so updating the
text to reflect that.

Fixes #74751

---------

Co-authored-by: Jasmin <[email protected]>
@c298lee
Copy link
Member

c298lee commented Jul 26, 2024

We decided to modify the text to accurately represent that a replay count is being shown due to complexity of getting a user count. We will follow up and create a hook that gets the user count in #75103

@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
3 participants