fix(replay): Update text to reflect replay count #75023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Bundle ReportChanges will increase total bundle size by 13.47kB ⬆️
|
michellewzhang
approved these changes
Jul 25, 2024
| @@ -270,9 +270,8 @@ function GroupReplaysTable({ | |||
| <ReplayCountHeader> | |||
| <IconUser size="sm" /> | |||
| {t( | |||
| 'Replay captured %s experiencing this issue across %s.', | |||
| tn('%s user', '%s users', replayCount ?? 0), | |||
| tn('%s event', '%s events', group.count) | |||
There was a problem hiding this comment.
why did we get rid of this line?
There was a problem hiding this comment.
I wasn't sure how to word it properly with the events count, updated to bring it back, lmk if you have any suggestions
There was a problem hiding this comment.
with @jas-kas 's suggestion i think it sounds fine!
jas-kas
reviewed
Jul 26, 2024
jas-kas
reviewed
Jul 26, 2024
jas-kas
approved these changes
Jul 26, 2024
Co-authored-by: Jasmin <[email protected]>
Co-authored-by: Jasmin <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are getting a replay count instead of a user count, so updating the text to reflect that.
Fixes #74751