Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(replay): Update text to reflect replay count #75023

Merged
merged 4 commits into from
Jul 26, 2024
Merged

fix(replay): Update text to reflect replay count #75023

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9cb8aac
update wording
c298lee Jul 25, 2024
51bfed2
update copy
c298lee Jul 26, 2024
7a78c09
Update static/app/components/events/eventReplay/replayClipSection.tsx
c298lee Jul 26, 2024
9732f8d
Update static/app/views/issueDetails/groupReplays/groupReplays.tsx
c298lee Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions static/app/components/events/eventReplay/replayClipSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {REPLAY_LOADING_HEIGHT} from 'sentry/components/events/eventReplay/consta
import LazyLoad from 'sentry/components/lazyLoad';
import LoadingIndicator from 'sentry/components/loadingIndicator';
import {ReplayGroupContextProvider} from 'sentry/components/replays/replayGroupContext';
import {t, tct} from 'sentry/locale';
import {t, tn} from 'sentry/locale';
import {space} from 'sentry/styles/space';
import type {Event} from 'sentry/types/event';
import type {Group} from 'sentry/types/group';
Expand Down Expand Up @@ -69,9 +69,10 @@ export function ReplayClipSection({event, group, replayId}: Props) {
seeAllReplaysButton && replayCount && replayCount > 1 ? (
<Fragment>
<div>
{tct('Replay captured [replayCount] users experiencing this issue', {
replayCount,
})}
{t(
'There are %s for this issue.',
tn('%s replay', '%s replays', replayCount ?? 0)
)}
</div>
{seeAllReplaysButton}
</Fragment>
Expand Down
4 changes: 2 additions & 2 deletions static/app/views/issueDetails/groupReplays/groupReplays.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,8 @@ function GroupReplaysTable({
<ReplayCountHeader>
<IconUser size="sm" />
{t(
'Replay captured %s experiencing this issue across %s.',
tn('%s user', '%s users', replayCount ?? 0),
'There are %s for this issue across %s.',
tn('%s replay', '%s replays', replayCount ?? 0),
tn('%s event', '%s events', group.count)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did we get rid of this line?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure how to word it properly with the events count, updated to bring it back, lmk if you have any suggestions

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with @jas-kas 's suggestion i think it sounds fine!

)}
</ReplayCountHeader>
Expand Down
Loading