Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(replay): rm experimental from onboarding #82655

Merged
merged 6 commits into from
Jan 6, 2025

Conversation

michellewzhang
Copy link
Member

@michellewzhang michellewzhang commented Dec 30, 2024

closes #82255

@michellewzhang michellewzhang requested a review from a team as a code owner December 30, 2024 16:23
@michellewzhang michellewzhang requested review from bruno-garcia and a team December 30, 2024 16:23
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 30, 2024
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Is React Native on a separate PR?

@michellewzhang
Copy link
Member Author

image

Is React Native on a separate PR?

oh good catch. RN is a different format:

import * as Sentry from '@sentry/react-native';
Sentry.init({
dsn: "${params.dsn.public}",
_experiments: {
replaysSessionSampleRate: 1.0,
replaysOnErrorSampleRate: 1.0,
},
integrations: [
Sentry.mobileReplayIntegration(),
],
});`;

is there a reference of what the code should look like in GA?

@bruno-garcia
Copy link
Member

is there a reference of what the code should look like in GA?

yeah, the source of truth is here: https://github.com/getsentry/sentry-react-native/pull/4384/files

e.g:

  Sentry.init({
    replaysSessionSampleRate: 1.0,
    replaysOnErrorSampleRate: 1.0,
    integrations: [
      Sentry.mobileReplayIntegration({
        maskAllImages: true,
        maskAllVectors: true,
        maskAllText: true,
      }),
    ],
  });

@michellewzhang
Copy link
Member Author

is there a reference of what the code should look like in GA?

yeah, the source of truth is here: https://github.com/getsentry/sentry-react-native/pull/4384/files

e.g:

  Sentry.init({
    replaysSessionSampleRate: 1.0,
    replaysOnErrorSampleRate: 1.0,
    integrations: [
      Sentry.mobileReplayIntegration({
        maskAllImages: true,
        maskAllVectors: true,
        maskAllText: true,
      }),
    ],
  });

updated!

@michellewzhang michellewzhang marked this pull request as draft January 2, 2025 22:11
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #82655   +/-   ##
=======================================
  Coverage   87.44%   87.44%           
=======================================
  Files        9419     9419           
  Lines      538332   538332           
  Branches    21060    21060           
=======================================
  Hits       470767   470767           
  Misses      67160    67160           
  Partials      405      405           

Copy link

codecov bot commented Jan 3, 2025

Bundle Report

Changes will increase total bundle size by 34.9kB (0.11%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 32.19MB 34.9kB (0.11%) ⬆️

@bruno-garcia
Copy link
Member

Lets default to 10% on sessions, and 100% on errors. As we do for Web Replay.

@bruno-garcia bruno-garcia merged commit 49adbf7 into master Jan 6, 2025
43 checks passed
@bruno-garcia bruno-garcia deleted the mz/onboarding-mobile-rm-experimental branch January 6, 2025 14:57
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Mobile Replay GA] Update In-Product Sidebar Onboarding
4 participants