-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(replay): rm experimental from onboarding #82655
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh good catch. RN is a different format: sentry/static/app/gettingStartedDocs/react-native/react-native.tsx Lines 79 to 90 in 9a9a114
is there a reference of what the code should look like in GA? |
yeah, the source of truth is here: https://github.com/getsentry/sentry-react-native/pull/4384/files e.g: Sentry.init({
replaysSessionSampleRate: 1.0,
replaysOnErrorSampleRate: 1.0,
integrations: [
Sentry.mobileReplayIntegration({
maskAllImages: true,
maskAllVectors: true,
maskAllText: true,
}),
],
}); |
updated! |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #82655 +/- ##
=======================================
Coverage 87.44% 87.44%
=======================================
Files 9419 9419
Lines 538332 538332
Branches 21060 21060
=======================================
Hits 470767 470767
Misses 67160 67160
Partials 405 405 |
Bundle ReportChanges will increase total bundle size by 34.9kB (0.11%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Lets default to 10% on sessions, and 100% on errors. As we do for Web Replay. |
closes #82255