Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(replay): rm experimental from onboarding #82655

Merged
merged 6 commits into from
Jan 6, 2025
Merged

ref(replay): rm experimental from onboarding #82655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0d99215
ref(replay): rm experimental from onboarding
michellewzhang Dec 30, 2024
9a9a114
:recycle: dont change flutter
michellewzhang Jan 2, 2025
abf4e44
:recycle: update RN
michellewzhang Jan 2, 2025
c963bfd
:recycle: update versions
michellewzhang Jan 2, 2025
4da70cf
Update static/app/gettingStartedDocs/react-native/react-native.tsx
michellewzhang Jan 3, 2025
1014a3f
session sample set to 0.1
bruno-garcia Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions static/app/gettingStartedDocs/android/android.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,18 +102,17 @@ SentryAndroid.init(context) { options ->
options.dsn = "${params.dsn.public}"
options.isDebug = true

// Currently under experimental options:
options.experimental.sessionReplay.onErrorSampleRate = 1.0
options.experimental.sessionReplay.sessionSampleRate = 1.0
options.sessionReplay.onErrorSampleRate = 1.0
options.sessionReplay.sessionSampleRate = 0.1
}`;

const getReplaySetupSnippetXml = () => `
<meta-data android:name="io.sentry.session-replay.on-error-sample-rate" android:value="1.0" />
<meta-data android:name="io.sentry.session-replay.session-sample-rate" android:value="1.0" />`;

const getReplayConfigurationSnippet = () => `
options.experimental.sessionReplay.redactAllText = true
options.experimental.sessionReplay.redactAllImages = true`;
options.sessionReplay.redactAllText = true
options.sessionReplay.redactAllImages = true`;

const onboarding: OnboardingConfig<PlatformOptions> = {
install: params =>
Expand Down Expand Up @@ -311,7 +310,7 @@ const replayOnboarding: OnboardingConfig<PlatformOptions> = {
{
type: StepType.INSTALL,
description: tct(
"Make sure your Sentry Android SDK version is at least 7.12.0. The easiest way to update through the Sentry Android Gradle plugin to your app module's [code:build.gradle] file.",
"Make sure your Sentry Android SDK version is at least 7.20.0. The easiest way to update through the Sentry Android Gradle plugin to your app module's [code:build.gradle] file.",
{code: <code />}
),
configurations: [
Expand Down Expand Up @@ -432,10 +431,8 @@ const replayOnboarding: OnboardingConfig<PlatformOptions> = {
},
],
verify: getReplayVerifyStep({
replayOnErrorSampleRateName:
'options\u200b.experimental\u200b.sessionReplay\u200b.onErrorSampleRate',
replaySessionSampleRateName:
'options\u200b.experimental\u200b.sessionReplay\u200b.sessionSampleRate',
replayOnErrorSampleRateName: 'options\u200b.sessionReplay\u200b.onErrorSampleRate',
replaySessionSampleRateName: 'options\u200b.sessionReplay\u200b.sessionSampleRate',
}),
nextSteps: () => [],
};
Expand Down
17 changes: 7 additions & 10 deletions static/app/gettingStartedDocs/apple/ios.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,14 +284,13 @@ SentrySDK.start(configureOptions: { options in
options.dsn = "${params.dsn.public}"
options.debug = true

// Currently under experimental options:
options.experimental.sessionReplay.onErrorSampleRate = 1.0
options.experimental.sessionReplay.sessionSampleRate = 1.0
options.sessionReplay.onErrorSampleRate = 1.0
options.sessionReplay.sessionSampleRate = 0.1
})`;

const getReplayConfigurationSnippet = () => `
options.experimental.sessionReplay.redactAllText = true
options.experimental.sessionReplay.redactAllImages = true`;
options.sessionReplay.redactAllText = true
options.sessionReplay.redactAllImages = true`;

const onboarding: OnboardingConfig<PlatformOptions> = {
install: params =>
Expand Down Expand Up @@ -658,7 +657,7 @@ const replayOnboarding: OnboardingConfig<PlatformOptions> = {
{
type: StepType.INSTALL,
description: t(
'Make sure your Sentry Cocoa SDK version is at least 8.31.1. If you already have the SDK installed, you can update it to the latest version with:'
'Make sure your Sentry Cocoa SDK version is at least 8.43.0. If you already have the SDK installed, you can update it to the latest version with:'
),
configurations: [
{
Expand Down Expand Up @@ -733,10 +732,8 @@ const replayOnboarding: OnboardingConfig<PlatformOptions> = {
},
],
verify: getReplayVerifyStep({
replayOnErrorSampleRateName:
'options\u200b.experimental\u200b.sessionReplay\u200b.onErrorSampleRate',
replaySessionSampleRateName:
'options\u200b.experimental\u200b.sessionReplay\u200b.sessionSampleRate',
replayOnErrorSampleRateName: 'options\u200b.sessionReplay\u200b.onErrorSampleRate',
replaySessionSampleRateName: 'options\u200b.sessionReplay\u200b.sessionSampleRate',
}),
nextSteps: () => [],
};
Expand Down
8 changes: 3 additions & 5 deletions static/app/gettingStartedDocs/react-native/react-native.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,8 @@ import * as Sentry from '@sentry/react-native';

Sentry.init({
dsn: "${params.dsn.public}",
_experiments: {
replaysSessionSampleRate: 1.0,
replaysOnErrorSampleRate: 1.0,
},
replaysSessionSampleRate: 0.1,
replaysOnErrorSampleRate: 1.0,
integrations: [
Sentry.mobileReplayIntegration(),
],
Expand Down Expand Up @@ -411,7 +409,7 @@ const replayOnboarding: OnboardingConfig = {
{
type: StepType.INSTALL,
description: t(
'Make sure your Sentry React Native SDK version is at least 5.26.0. If you already have the SDK installed, you can update it to the latest version with:'
'Make sure your Sentry React Native SDK version is at least 6.5.0. If you already have the SDK installed, you can update it to the latest version with:'
),
configurations: [
{
Expand Down
Loading