ref(clippy): Use <dyn Fail> for trait #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bare trait usage syntax is deprecated.
Swatinem
approved these changes
Mar 22, 2021
| @@ -52,7 +52,7 @@ impl ApiErrorResponse { | |||
| pub fn from_fail(fail: &dyn Fail) -> ApiErrorResponse { | |||
| let mut messages = vec![]; | |||
|
|
|||
| for cause in Fail::iter_chain(fail) { | |||
| for cause in <dyn Fail>::iter_chain(fail) { | |||
There was a problem hiding this comment.
btw, this is:
rust-lang/rust#82868 (fixing rust-lang/rust#65371)
It seemed weird at first, but does make sense. Also looks like that these will become hard errors in Rust 2021 soon: rust-lang/rust#83213
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bare trait usage syntax is deprecated.
#skip-changelog