Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(clippy): Use <dyn Fail> for trait #407

Merged
merged 1 commit into from
Mar 22, 2021
Merged

ref(clippy): Use <dyn Fail> for trait #407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/middlewares.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ impl ApiErrorResponse {
pub fn from_fail(fail: &dyn Fail) -> ApiErrorResponse {
let mut messages = vec![];

for cause in Fail::iter_chain(fail) {
for cause in <dyn Fail>::iter_chain(fail) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, this is:
rust-lang/rust#82868 (fixing rust-lang/rust#65371)

It seemed weird at first, but does make sense. Also looks like that these will become hard errors in Rust 2021 soon: rust-lang/rust#83213

let msg = cause.to_string();
if !messages.contains(&msg) {
messages.push(msg);
Expand Down