Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example set value results in stack trace #461

Closed
MansM opened this issue May 2, 2019 · 1 comment
Closed

example set value results in stack trace #461

MansM opened this issue May 2, 2019 · 1 comment
Assignees
Labels

Comments

@MansM
Copy link

MansM commented May 2, 2019

sops --set '["app2"]["key"] "app2keystringvalue"' existingfile.yml

anic: interface conversion: interface {} is string, not sops.TreeBranches

goroutine 1 [running]:
main.jsonValueToTreeInsertableValue(0x7ffeefbff763, 0x14, 0x190ec78, 0x1, 0x7ffeefbff753, 0xf)
	/private/tmp/sops-20190418-13511-18dvxtu/sops-3.3.0/src/go.mozilla.org/sops/cmd/sops/main.go:863 +0x35a
main.extractSetArguments(0x7ffeefbff753, 0x24, 0xc0000c28a0, 0x7ffeefbff753, 0x24, 0x0, 0x0, 0x1aacac0, 0x176ca8e)
	/private/tmp/sops-20190418-13511-18dvxtu/sops-3.3.0/src/go.mozilla.org/sops/cmd/sops/main.go:875 +0xd6
main.main.func5(0xc000176580, 0x0, 0x0)
	/private/tmp/sops-20190418-13511-18dvxtu/sops-3.3.0/src/go.mozilla.org/sops/cmd/sops/main.go:564 +0x231d
go.mozilla.org/sops/vendor/gopkg.in/urfave/cli%2ev1.HandleAction(0x17f8040, 0x1947068, 0xc000176580, 0x0, 0x0)
	/private/tmp/sops-20190418-13511-18dvxtu/sops-3.3.0/src/go.mozilla.org/sops/vendor/gopkg.in/urfave/cli.v1/app.go:490 +0xc8
go.mozilla.org/sops/vendor/gopkg.in/urfave/cli%2ev1.(*App).Run(0xc000200ea0, 0xc0000c8000, 0x4, 0x4, 0x0, 0x0)
	/private/tmp/sops-20190418-13511-18dvxtu/sops-3.3.0/src/go.mozilla.org/sops/vendor/gopkg.in/urfave/cli.v1/app.go:264 +0x590
main.main()
	/private/tmp/sops-20190418-13511-18dvxtu/sops-3.3.0/src/go.mozilla.org/sops/cmd/sops/main.go:649 +0x2578
OS: macOS high sierra
sops -v
sops 3.3.0

brew info sops
sops: stable 3.3.0 (bottled), HEAD
Editor of encrypted files
https://github.com/mozilla/sops
/usr/local/Cellar/sops/3.3.0 (5 files, 22MB) *
  Poured from bottle on 2019-04-30 at 17:40:11
From: https://github.com/Homebrew/homebrew-core/blob/master/Formula/sops.rb

@autrilla autrilla added the bug label May 2, 2019
@thepont
Copy link

thepont commented May 22, 2019

This bug is also occurring on Linux sops 3.3.0 (using the Arch linux AUR sops package https://aur.archlinux.org/packages/sops/).

Does not seem to happen on version 3.2.0 on OSX.

@ajvb ajvb self-assigned this May 23, 2019
ajvb added a commit that referenced this issue May 23, 2019
Adds back support for string values in --set, while retaining support
for yaml multidoc that caused this bug.

Fixes #461
ajvb added a commit that referenced this issue May 28, 2019
* Allow set "json value" to be a string.

Adds back support for string values in --set, while retaining support
for yaml multidoc that caused this bug.

Fixes #461

* Add functional test for --set'ing strings
@ajvb ajvb added this to the sops 3.4.0 milestone Jun 7, 2019
@ajvb ajvb closed this as completed in e9e1e87 Jun 11, 2019
@ajvb ajvb removed this from the sops 3.4.0 milestone Jun 13, 2019
ajvb added a commit that referenced this issue Sep 11, 2019
* Changes to travis config and docs for using develop (#462)

* Fixes integration tests in travis to not run on PR's (they will now
run on merges into `develop` and `master`)
* Change README.rst and CONTRIBUTING.md to reflect the use of `develop`
as the primary development branch

* use golang 1.12 for building sops

* pgp/keysource: Check size of key fingerprint

Make sure the key fingerprint is longer than 16 characters before
slicing it.

Closes #463

* Allow set "json value" to be a string. (#468)

* Allow set "json value" to be a string.

Adds back support for string values in --set, while retaining support
for yaml multidoc that caused this bug.

Fixes #461

* Add functional test for --set'ing strings

* Vendoring update (#472)

It's been around 9 months since our last vendor update. This is also
needed for some new features being worked on for sops workspace.

Additionally, this PR regenerates the kms mocks.

* Remove duplicate sentence from readme (#475)

* 3.3.1 bump and release notes (#477)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants