Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendoring update #472

Merged
merged 1 commit into from
Jun 6, 2019
Merged

Vendoring update #472

merged 1 commit into from
Jun 6, 2019

Conversation

ajvb
Copy link
Contributor

@ajvb ajvb commented Jun 6, 2019

It's been around 9 months since our last vendor update. This is also needed for some new features being worked on for sops workspace. (i.e. sops publish)

Additionally, this PR regenerates the kms mocks.

Letting this sit in develop for a bit would also probably be a good idea.

It's been around 9 months since our last vendor update. This is also
needed for some new features being worked on for sops workspace.

Additionally, this PR regenerates the kms mocks.
@ajvb ajvb requested a review from autrilla June 6, 2019 16:50
Copy link
Contributor

@autrilla autrilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm assuming tests pass. Also yay for sneak peek at sops publish :D

@codecov-io
Copy link

Codecov Report

Merging #472 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #472   +/-   ##
========================================
  Coverage    36.38%   36.38%           
========================================
  Files           20       20           
  Lines         2718     2718           
========================================
  Hits           989      989           
  Misses        1640     1640           
  Partials        89       89

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8e60a1...5296c94. Read the comment docs.

@autrilla autrilla self-requested a review June 6, 2019 17:00
Copy link
Contributor

@autrilla autrilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to approve, heh

@ajvb
Copy link
Contributor Author

ajvb commented Jun 6, 2019

@autrilla :D

@ajvb ajvb merged commit 15dfcfa into develop Jun 6, 2019
@ajvb ajvb deleted the vendoring-update branch June 6, 2019 17:40
ajvb added a commit that referenced this pull request Jun 11, 2019
* Changes to travis config and docs for using develop (#462)

* Fixes integration tests in travis to not run on PR's (they will now
run on merges into `develop` and `master`)
* Change README.rst and CONTRIBUTING.md to reflect the use of `develop`
as the primary development branch

* use golang 1.12 for building sops

* pgp/keysource: Check size of key fingerprint

Make sure the key fingerprint is longer than 16 characters before
slicing it.

Closes #463

* Allow set "json value" to be a string. (#468)

* Allow set "json value" to be a string.

Adds back support for string values in --set, while retaining support
for yaml multidoc that caused this bug.

Fixes #461

* Add functional test for --set'ing strings

* Vendoring update (#472)

It's been around 9 months since our last vendor update. This is also
needed for some new features being worked on for sops workspace.

Additionally, this PR regenerates the kms mocks.

* Remove duplicate sentence from readme (#475)

* 3.3.1 bump and release notes (#477)
ajvb added a commit that referenced this pull request Sep 11, 2019
* Changes to travis config and docs for using develop (#462)

* Fixes integration tests in travis to not run on PR's (they will now
run on merges into `develop` and `master`)
* Change README.rst and CONTRIBUTING.md to reflect the use of `develop`
as the primary development branch

* use golang 1.12 for building sops

* pgp/keysource: Check size of key fingerprint

Make sure the key fingerprint is longer than 16 characters before
slicing it.

Closes #463

* Allow set "json value" to be a string. (#468)

* Allow set "json value" to be a string.

Adds back support for string values in --set, while retaining support
for yaml multidoc that caused this bug.

Fixes #461

* Add functional test for --set'ing strings

* Vendoring update (#472)

It's been around 9 months since our last vendor update. This is also
needed for some new features being worked on for sops workspace.

Additionally, this PR regenerates the kms mocks.

* Remove duplicate sentence from readme (#475)

* 3.3.1 bump and release notes (#477)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants