Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xmpp URL generation breaks #747

Closed
ghost opened this issue Jul 15, 2019 · 6 comments
Closed

xmpp URL generation breaks #747

ghost opened this issue Jul 15, 2019 · 6 comments
Labels

Comments

@ghost
Copy link

ghost commented Jul 15, 2019

given

the following is generated:

<a href="http://127.0.0.1:1111/xmpp:[email protected]">[email protected]</a>

Is this intended Markdown behavior or can this parsing of URIs be improved?

Expected result was an xmpp:... in the href.

@Keats
Copy link
Collaborator

Keats commented Jul 15, 2019

Which version of Zola? Sounds like a bug

@Keats Keats added the bug label Jul 15, 2019
@Keats
Copy link
Collaborator

Keats commented Jul 15, 2019

I've added a test for it in the next branch but it seems to be doing the right thing there: <p><a href="xmpp:[email protected]">[email protected]</a></p>

@ghost
Copy link
Author

ghost commented Jul 16, 2019

This is on df720a5, I'm trying a new build soon to see if it is fixed.

Thanks.

@Keats
Copy link
Collaborator

Keats commented Aug 5, 2019

Is it working for you?

@ghost
Copy link
Author

ghost commented Aug 6, 2019

I can try this weekend if I can schedule some time for this.

@ghost
Copy link
Author

ghost commented Aug 10, 2019

Okay, we can probably close this. I'm wrapping up packaging the 0.8 release for pkgsrc-wip today and will test a newer commit for my personal checkout. I'm fairly positive that your test is alright, I'll reopen this if I run into the issue again.

Thanks!

@ghost ghost closed this as completed Aug 10, 2019
Keats pushed a commit that referenced this issue Oct 10, 2019
…eme (#817)

Links that start with a scheme (e.g., `tel:18008675309`) inadvertently
had a URL prefix prepended. Previously, only `mailto:` was handled, but
given the sheer number of [registered URI schemes][uri-schemes], a loose
pattern matcher is used to detect schemes instead.

External links, as identified by the renderer, are now limited to `http`
and `https` schemes.

Fixes #747 and fixes #816.

[uri-schemes]: https://www.iana.org/assignments/uri-schemes/uri-schemes.xhtml
Keats pushed a commit that referenced this issue Oct 24, 2019
…eme (#817)

Links that start with a scheme (e.g., `tel:18008675309`) inadvertently
had a URL prefix prepended. Previously, only `mailto:` was handled, but
given the sheer number of [registered URI schemes][uri-schemes], a loose
pattern matcher is used to detect schemes instead.

External links, as identified by the renderer, are now limited to `http`
and `https` schemes.

Fixes #747 and fixes #816.

[uri-schemes]: https://www.iana.org/assignments/uri-schemes/uri-schemes.xhtml
Keats pushed a commit that referenced this issue Feb 3, 2020
…eme (#817)

Links that start with a scheme (e.g., `tel:18008675309`) inadvertently
had a URL prefix prepended. Previously, only `mailto:` was handled, but
given the sheer number of [registered URI schemes][uri-schemes], a loose
pattern matcher is used to detect schemes instead.

External links, as identified by the renderer, are now limited to `http`
and `https` schemes.

Fixes #747 and fixes #816.

[uri-schemes]: https://www.iana.org/assignments/uri-schemes/uri-schemes.xhtml
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant