rendering: Avoid prepending URL prefix to links that start with a scheme #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Links that start with a scheme (e.g., `tel:18008675309`) inadvertently had a URL prefix prepended. Previously, only `mailto:` was handled, but given the sheer number of [registered URI schemes][uri-schemes], a loose pattern matcher is used to detect schemes instead. External links, as identified by the renderer, are now limited to `http` and `https` schemes. Fixes #747 and fixes #816. [uri-schemes]: https://www.iana.org/assignments/uri-schemes/uri-schemes.xhtml
Keats
requested changes
Oct 10, 2019
|
Thanks! |
Keats
pushed a commit
that referenced
this pull request
Oct 24, 2019
…eme (#817) Links that start with a scheme (e.g., `tel:18008675309`) inadvertently had a URL prefix prepended. Previously, only `mailto:` was handled, but given the sheer number of [registered URI schemes][uri-schemes], a loose pattern matcher is used to detect schemes instead. External links, as identified by the renderer, are now limited to `http` and `https` schemes. Fixes #747 and fixes #816. [uri-schemes]: https://www.iana.org/assignments/uri-schemes/uri-schemes.xhtml
Keats
pushed a commit
that referenced
this pull request
Feb 3, 2020
…eme (#817) Links that start with a scheme (e.g., `tel:18008675309`) inadvertently had a URL prefix prepended. Previously, only `mailto:` was handled, but given the sheer number of [registered URI schemes][uri-schemes], a loose pattern matcher is used to detect schemes instead. External links, as identified by the renderer, are now limited to `http` and `https` schemes. Fixes #747 and fixes #816. [uri-schemes]: https://www.iana.org/assignments/uri-schemes/uri-schemes.xhtml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links that start with a scheme (e.g., "tel:18008675309") inadvertently
had a URL prefix prepended. Previously, only
mailto:was handled, butgiven the sheer number of registered URI schemes, a loose
pattern matcher is used to detect schemes instead.
External links, as identified by the renderer, are now limited to
httpand
httpsschemes.Fixes #747 and fixes #816.
IMPORTANT: Please do not create a Pull Request adding a new feature without discussing it first.
The place to discuss new features is the forum: https://zola.discourse.group/
If you want to add a new feature, please open a thread there first in the feature requests section.
Sanity check:
Code changes
(Delete or ignore this section for documentation changes)
nextbranch?If the change is a new feature or adding to/changing an existing one: