Compute canonical path before adjusting parent path

[phil-opp]

Fixes #854

[phil-opp]

I think we also need to strip the language tag from the filename when generating the canonical path, otherwise translations are not found. Do you want me to add this change to this PR or do you prefer when I open a new one?

[Keats]

I mean that's weird that it was not doing it, I swear I had code to handle that.. :(
Can you add some tests while you're there? At least a regression test with a link to the GH issue.

[phil-opp]

I mean that's weird that it was not doing it, I swear I had code to handle that.. :(

Maybe you mean this code?

zola/components/library/src/content/file_info.rs

Lines 114 to 143 in 6d7c95e

	/// Look for a language in the filename.
	/// If a language has been found, update the name of the file in this struct to
	/// remove it and return the language code
	pub fn find_language(&mut self, config: &Config) -> Result<String> {
	// No languages? Nothing to do
	if !config.is_multilingual() {
	return Ok(config.default_language.clone());
	}
	if !self.name.contains('.') {
	return Ok(config.default_language.clone());
	}
	// Go with the assumption that no one is using `.` in filenames when using i18n
	// We can document that
	let mut parts: Vec<String> = self.name.splitn(2, '.').map(|s| s.to_string()).collect();
	// The language code is not present in the config: typo or the user forgot to add it to the
	// config
	if !config.languages_codes().contains(&parts[1].as_ref()) {
	bail!("File {:?} has a language code of {} which isn't present in the config.toml `languages`", self.path, parts[1]);
	}
	self.name = parts.swap_remove(0);
	self.canonical = self.parent.join(&self.name);
	let lang = parts.swap_remove(0);
	Ok(lang)
	}
	}

This line seems to have the same problem:

zola/components/library/src/content/file_info.rs

Line 138 in 6d7c95e

self.canonical = self.parent.join(&self.name);

You're using the adjusted parent field to create the canonical path again.

[phil-opp]

I pushed a second commit that also fixes the issue in find_language.

[phil-opp]

I added some basic regression tests for the two commits.

[Keats]

I think the reason for those bugs is that in my mind the canonical path was /home/vincent/code/site/content/posts/tutorials/python.
Anyway, thanks a lot!