-
Notifications
You must be signed in to change notification settings - Fork 995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Rust 2018 edition #885
Conversation
27b67af
to
614e957
Compare
For whatever reason, CI was running into errors related to the |
For the extern crate importing macros, you need to import the macros manually where they are used. I don't know why that would wok locally though |
ee46025
to
e6abcbf
Compare
In this latest commit, I've also removed the For what it's worth, I hadn't removed the |
07e8016
to
fc21781
Compare
The components are now using the 2018 edition as well, with It turns out that the reason why my local tests were different than CI was because I was mistakenly not using the |
Ah, that happens a lot to me as well :p |
fc21781
to
e97c453
Compare
I rebased this, resolved the conflicts, and made sure it builds/tests fine, so it should be good to go. |
Perfect, thanks! |
Hyper 0.13 uses async but async functions aren't permitted in the 2015 edition of Rust. This migrates Zola to the 2018 edition, so we can continue moving forward with #782.
The main changes to make this work were related to path clarity. Besides that, this allows us to drop some
extern crate
statements as well. There may be more tidying that can be done but this at least compiles/tests correctly.