Fix benchmarks (rendering, site) #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Restore #![feature(test)] and extern crate test; statements, which were mistakenly removed as part of the Rust 2018 edition migration. * Fix rendering benchmark's usage of RenderContext. 6 parameters were provided when 5 were expected.
|
Most of the benches are not actually used at all by anyone I think. I'll have a look and see if some can be removed. Thanks! |
Keats
pushed a commit
that referenced
this pull request
Feb 3, 2020
* Restore #![feature(test)] and extern crate test; statements, which were mistakenly removed as part of the Rust 2018 edition migration. * Fix rendering benchmark's usage of RenderContext. 6 parameters were provided when 5 were expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that I broke benchmarks in #885 because I was a little heavy-handed in my removal of
extern cratestatements and attributes. This restores the necessary#![feature(test)]andextern crate test;for these benchmarks to work.I fixed the
RenderContext::new()errors in the rendering benchmark, where six parameters were provided but five were expected.Past this, the
/components/site/benches/load.rsbenchmark fails for some reason and simply gives anerror: bench failedmessage. If you have any insight on how to fix this, I can try to tackle it in this PR, otherwise you can take care of it sometime later.