Skip to content
This repository has been archived by the owner on Jan 29, 2025. It is now read-only.

hlsl-out: Add support for push constants #2005

Merged
merged 4 commits into from
Aug 29, 2022

Conversation

JCapucho
Copy link
Collaborator

Push constants need to be configured by the consumer which must pass the
bind target of the constant buffer used for the push constants.

Closes #1782

src/back/hlsl/writer.rs Outdated Show resolved Hide resolved
tests/out/hlsl/push-constants.hlsl Show resolved Hide resolved
@JCapucho JCapucho requested a review from cwfitzgerald August 14, 2022 17:10
@JCapucho JCapucho force-pushed the hlsl-push-constants branch from df14159 to e0bcacf Compare August 15, 2022 13:58
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems well tested and generally g2g.

@cwfitzgerald
Copy link
Member

Seems to just need a rebase.

Push constants need to be configured by the consumer which must pass the
bind target of the constant buffer used for the push constants.
@JCapucho JCapucho force-pushed the hlsl-push-constants branch from e0bcacf to 423221c Compare August 29, 2022 10:54
@JCapucho JCapucho merged commit 9df243c into gfx-rs:master Aug 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hlsl-out] Implement push constants
2 participants