dx12: Add support for push constants #2866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCapucho
force-pushed
the
dx12-push-constants
branch
from
51a6831 to
3d484da
Compare
JCapucho
force-pushed
the
dx12-push-constants
branch
from
3d484da to
e3d8dcd
Compare
JCapucho
force-pushed
the
dx12-push-constants
branch
from
e3d8dcd to
c91d5c0
Compare
cwfitzgerald
approved these changes
Sep 19, 2022
JCapucho
force-pushed
the
dx12-push-constants
branch
from
c91d5c0 to
9b4eb1c
Compare
|
CI is failing on vulkan tests... on dx12 changes 🙃 |
|
Hmm, seems to be spurious |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy(shows some warning unrelated to my work).RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable (not applicable).Connections
Requires gfx-rs/naga#2005(merged)Closes #2829
Description
Adds support for push constants on the dx12 backend by using a slot on the root signature for a constant buffer.
Testing
Tested with a very basic cube program, needs more testing