Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

components from primeng are not colored properly #64

Closed
sheamer opened this issue Oct 17, 2022 · 7 comments
Closed

components from primeng are not colored properly #64

sheamer opened this issue Oct 17, 2022 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@sheamer
Copy link

sheamer commented Oct 17, 2022

Describe the bug
-Before the latest update this works fine, components from primeng like , , , used to be colored properly. but after the update all of those custom tag components are not colored (white text only) and everything in it is also not colored properly:

List of installed/enabled extensions

  • vscode-angular-html
  • Material Icon Theme
  • IntelliCode API Usage Examples

OS (please provide the following information):

  • Windows 10

Expected behavior

  • Custom tags from primeng should also be colored properly in html

1

@sheamer sheamer added the bug Something isn't working label Oct 17, 2022
@ghaschel
Copy link
Owner

On it.

@ghaschel
Copy link
Owner

Along with the custom-elements bugfix, I intend to allow PrimeNG tags to be personalized just as with Angular Material... But for that, I need to track all of the PrimeNG elements, and I was able to get all of these from their docs:

Please, let me know if there is any component missing so that I can add to the list.

<p-autocomplete></p-autocomplete>
<p-calendar></p-calendar>
<p-cascadeSelect></p-cascadeSelect>
<p-checkbox></p-checkbox>
<p-chips></p-chips>
<p-colorPicker></p-colorPicker>
<p-dropdown></p-dropdown>
<p-editor></p-editor>
<p-inputMask></p-inputMask>
<p-inputSwitch></p-inputSwitch>
<p-inputNumber></p-inputNumber>
<p-knob></p-knob>
<p-listbox></p-listbox>
<p-multiSelect></p-multiSelect>
<p-password></p-password>
<p-radioButton></p-radioButton>
<p-rating></p-rating>
<p-slider></p-slider>
<p-selectButton></p-selectButton>
<p-toggleButton></p-toggleButton>
<p-treeSelect></p-treeSelect>
<p-triStateCheckbox></p-triStateCheckbox>
<p-button></p-button>
<p-splitButton></p-splitButton>
<p-speedDial></p-speedDial>
<p-dataView></p-dataView>
<p-fullCalendar></p-fullCalendar>
<p-gmap></p-gmap>
<p-orderList></p-orderList>
<p-organizationChart></p-organizationChart>
<p-paginator></p-paginator>
<p-pickList></p-pickList>
<p-table></p-table>
<p-tableHeaderCheckbox></p-tableHeaderCheckbox>
<p-sortIcon></p-sortIcon>
<p-columnFilter></p-columnFilter>
<p-tableCheckbox></p-tableCheckbox>
<p-dialog></p-dialog>
<p-skeleton></p-skeleton>
<p-toast></p-toast>
<p-cellEditor></p-cellEditor>
<p-contextMenu></p-contextMenu>
<p-toolbar></p-toolbar>
<p-fileUpload></p-fileUpload>
<p-confirmDialog></p-confirmDialog>
<p-tableRadioButton></p-tableRadioButton>
<p-timeline></p-timeline>
<p-card></p-card>
<p-tree></p-tree>
<p-treeTable></p-treeTable>
<p-treeTableToggler></p-treeTableToggler>
<p-treeTableSortIcon></p-treeTableSortIcon>
<p-treeTableCheckbox></p-treeTableCheckbox>
<p-treeTableCellEditor></p-treeTableCellEditor>
<p-virtualScroller></p-virtualScroller>
<p-scroller></p-scroller>
<p-accordion></p-accordion>
<p-accordionTab></p-accordionTab>
<p-divider></p-divider>
<p-fieldset></p-fieldset>
<p-panel></p-panel>
<p-menu></p-menu>
<p-splitter></p-splitter>
<p-scrollPanel></p-scrollPanel>
<p-tabView></p-tabView>
<p-tabPanel></p-tabPanel>
<p-confirmPopup></p-confirmPopup>
<p-overlayPanel></p-overlayPanel>
<p-breadcrumb></p-breadcrumb>
<p-dock></p-dock>
<p-megaMenu></p-megaMenu>
<p-menubar></p-menubar>
<p-panelMenu></p-panelMenu>
<p-slideMenu></p-slideMenu>
<p-steps></p-steps>
<p-tabMenu></p-tabMenu>
<p-tieredMenu></p-tieredMenu>
<p-chart></p-chart>
<p-messages></p-messages>
<p-carousel></p-carousel>
<p-galleria></p-galleria>
<p-image></p-image>
<p-avatar></p-avatar>
<p-avatarGroup></p-avatarGroup>
<p-badge></p-badge>
<p-blockUI></p-blockUI>
<p-captcha></p-captcha>
<p-chips></p-chips>
<p-chip></p-chip>
<p-inplace></p-inplace>
<p-progressBar></p-progressBar>
<p-progressSpinner></p-progressSpinner>
<p-scrollTop></p-scrollTop>
<p-skeleton></p-skeleton>
<p-tag></p-tag>
<p-terminal></p-terminal>

@Daranix
Copy link

Daranix commented Oct 18, 2022

@ghaschel

Some additional tags:

[
    "p-header",
    "p-autoComplete",
    "p-cascadeSelectSub",
    "p-contextMenuSub",
    "p-dropdownItem",
    "p-dynamicDialog",
    "p-inplaceDisplay",
    "p-lightbox",
    "p-menubarSub",
    "p-message",
    "p-multiSelectItem",
    "p-panelMenuSub",
    "p-sidebar",
    "p-slideMenuSub",
    "p-spinner",
    "p-tieredMenuSub",
    "p-toastItem",
    "p-treeNode"
]

@ghaschel
Copy link
Owner

Thanks for the tags. It will be on the next release.

ghaschel added a commit that referenced this issue Oct 25, 2022
…ents

tests not as good as I wanted to be. I will publish this to fix the issues adn get feedbacks

#63, #64, #65, #68
@ghaschel
Copy link
Owner

This was implemented on 2.2.1.

Feel free to reopen this issue or open a new one if there's something wrong, or even to request support for new tags

@sheamer
Copy link
Author

sheamer commented Oct 26, 2022

@ghaschel I'm a fan of your work. Thank you for this!

@ghaschel
Copy link
Owner

Thank you, I appreciate it. You just made my day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants