Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Legacy Colors not appling correct colors #65

Closed
ghaschel opened this issue Oct 17, 2022 · 1 comment
Closed

Set Legacy Colors not appling correct colors #65

ghaschel opened this issue Oct 17, 2022 · 1 comment
Assignees
@ghaschel
Labels
bug Something isn't working

Comments

@ghaschel
Copy link
Owner

Describe the bug

  • "Set Legacy Colors" command applying colors based on the dark-plus-syntax.
  • This is both a bug and a enhancement.

Expected behavior

  • Should get the colors from the current theme
@ghaschel ghaschel added the bug Something isn't working label Oct 17, 2022
@ghaschel ghaschel self-assigned this Oct 17, 2022
@ghaschel ghaschel mentioned this issue Oct 17, 2022
Closed
@ghaschel ghaschel reopened this Oct 18, 2022
ghaschel added a commit that referenced this issue Oct 25, 2022
@ghaschel
feat(per-theme support): per-theme support. some performance improvem…
9106151 
…ents

tests not as good as I wanted to be. I will publish this to fix the issues adn get feedbacks

#63, #64, #65, #68
@ghaschel
Copy link
Owner Author

This was fixed and implemented in v2.2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghaschel ghaschel

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ghaschel