-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an Arc-/Rc-based reader #294
Comments
I'm going to look into using https://crates.io/crates/bytes (or at least use its ideas). |
It seems that it is similar to the |
If I'll mmap a file I'll have some |
SGTM! |
Some initial ground work being laid in #295 |
An easy way to define a custom `Reader` implementation with a reference to a generic buffer of bytes and an associated endianity. Fix gimli-rs#294
https://www.reddit.com/r/rust/comments/8fcm5i/a_sampling_cpu_profiler_for_linux_written_in_rust/dy2mm2a/?context=3
I think we don't want to just make
EndianBuf
but with replacing the&[u8]
withArc<[u8]>
, because that means that slicing or splitting the reader would require copying the data. We want something like(start, end, Arc<[u8]>)
and have slicing/splitting just change the start and end indices and bump the ref count.cc @koute
The text was updated successfully, but these errors were encountered: