Rename EndianBuf to EndianSlice

[fitzgen]

Makes it more clear that it isn't an owning pointer, and clears the way for adding an owned arc/rc/whatever version in #294

[coveralls]

Coverage decreased (-0.01%) to 92.395% when pulling 7011449 on fitzgen:rename-EndianBuf-to-EndianSlice into c13119b on gimli-rs:master.

[philipc]

I agree it's a better name, but not completely convinced its worth the churn for users of the library (they'll probably have their variables called buf still).

Needs a couple of changes for rustfmt.

[philipc]

This needs updating.

[philipc]

Worth renaming this too?

[fitzgen]

I agree it's a better name, but not completely convinced its worth the churn for users of the library (they'll probably have their variables called buf still).

Did you see that there is a type alias type EndianBuf = EndianSlice; to ease upgrades? It is marked deprecated, with a note saying that the type has been renamed. Should hopefully mean that upgrading isn't actually very hard.

[fitzgen]

Which rustfmt have you been using? I just ran the latest nightly's rustfmt-preview component on rustup and it is introducing a ton of changes outside of the files I touched here.

[philipc]

The stable channel rustfmt-preview from rustc 1.25.

[fitzgen]

Huh. Even with cargo +stable fmt and

$ rustc +stable --version
rustc 1.25.0 (84203cac6 2018-03-25)

I'm still getting lots of unrelated formatting changes.

[philipc]

Don't know what's going on then. I'll run it when I rebase my PR.

$ rustc +stable --version
rustc 1.25.0 (84203cac6 2018-03-25)
$ cargo +stable fmt --version
0.3.8-nightly (346238f 2018-02-04)