[NO JIRA]: Fix incorrect custom prop type in calendar (Skyscanner#2308)

giriawu · Dec 9, 2021 · 4fc607a · 4fc607a
1 parent ce955d6
commit 4fc607a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/UNRELEASED.md b/UNRELEASED.md
@@ -10,6 +10,10 @@
 - bpk-component-badge:
   - Fixed a misalignment of height of the badge when an icon variant is being used.
 
+- bpk-component-calendar:
+  - Fixed an issue with custom `SelectionConfiguration` prop type where `type` was not correctly typed and threw a console error.
+
 **Added:**
 - bpk-component-textarea:
-  - Add new property `large` (optional) in textarea component with larger default height.
+  - Add new property `large` (optional) in textarea component with larger default height.
+
diff --git a/packages/bpk-component-calendar/src/custom-proptypes.js b/packages/bpk-component-calendar/src/custom-proptypes.js
@@ -56,12 +56,12 @@ const CALENDAR_SELECTION_TYPE = {
 };
 
 const SelectionConfigurationSingle = PropTypes.shape({
-  type: CALENDAR_SELECTION_TYPE.single,
+  type: PropTypes.oneOf([CALENDAR_SELECTION_TYPE.single]),
   date: PropTypes.instanceOf(Date),
 });
 
 const SelectionConfigurationRange = PropTypes.shape({
-  type: CALENDAR_SELECTION_TYPE.range,
+  type: PropTypes.oneOf([CALENDAR_SELECTION_TYPE.range]),
   startDate: DateType('selectionConfiguration'),
   endDate: DateType('selectionConfiguration'),
 });