Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mingw-w64-git-cv2pdb: add ARM64 support #435

Closed

Conversation

dennisameling
Copy link
Contributor

@dennisameling dennisameling commented Sep 17, 2022

Needs rainers/cv2pdb#81 to add ARM64 support (merged ✅)

Tested with MINGW_ARCH=clangarm64 makepkg-mingw -i and things work as expected:

$ cv2pdb --help
Convert DMD CodeView/DWARF debug information to PDB files, Version 0.52
Copyright (c) 2009-2012 by Rainer Schuetze, All Rights Reserved

License for redistribution is given by the Artistic License 2.0
see file LICENSE for further details

usage: --help [-D<version>|-C|-n|-e|-s<C>|-p<embedded-pdb>] <exe-file> [new-exe-file] [pdb-file]

@dennisameling dennisameling changed the title [WIP] ARM64 support for cv2pdb mingw-w64-git-cv2pdb: add ARM64 support Sep 19, 2022
@dennisameling dennisameling marked this pull request as ready for review September 19, 2022 09:58
@dennisameling
Copy link
Contributor Author

@dscho my upstream PR has been merged. Note that this PR bumps the version to the latest commit of cv2pdb, so you might want to do some checks if the x64 version also keeps working as it should.

Copy link
Member

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not totally opposed to this PR, but I wonder why we bother with cv2pdb on ARM64 because we use clang to compile for ARM64, right? And clang optionally generates .pdb itself... So all we would need to do is to ask clang to generate it, instead of building without .pdbs and then generating .pdb files using cv2pdb after the fact...

@@ -3,7 +3,7 @@
_realname=cv2pdb
pkgbase="mingw-w64-${_realname}"
pkgname=("${MINGW_PACKAGE_PREFIX}-${_realname}")
pkgver=0.50
pkgver=0.51.8.g9286b93
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to wait for a full release than to upgrade to an interim version.

@dscho
Copy link
Member

dscho commented Sep 22, 2022

PR build / build-packages (mingw-w64-cv2pdb) (pull_request) Failing after 8m

Hmm. This looks as if the build wants to call git tag and is missing a configured user.

@dennisameling would you mind cherry-picking 1c34c0d to see whether that fixes the build?

The `mingw-w64-cv2pdb` build, for example, wants to be able to call `git
tag`, which requires a user to be configured. Let's do that, then.

Signed-off-by: Johannes Schindelin <[email protected]>
@dennisameling
Copy link
Contributor Author

@dennisameling would you mind cherry-picking 1c34c0d to see whether that fixes the build?

Thanks! That resulted in:

D:\a\_temp\817b228c-038e-4e8b-930c-a2540b812488.sh: line 7: syntax error: unexpected end of file
Error: Process completed with exit code 2.

You might want to remove the && at the end of the Bash script 😊

@dennisameling
Copy link
Contributor Author

This is no longer needed as I'm now using Clang's built-in functionality to generate PDBs in git-for-windows/MINGW-packages#56. Thanks for the suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants