-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mingw-w64-git-cv2pdb: add ARM64 support #435
Conversation
Signed-off-by: Dennis Ameling <[email protected]>
90e56d9
to
dfa2dbe
Compare
@dscho my upstream PR has been merged. Note that this PR bumps the version to the latest commit of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not totally opposed to this PR, but I wonder why we bother with cv2pdb
on ARM64 because we use clang to compile for ARM64, right? And clang optionally generates .pdb
itself... So all we would need to do is to ask clang to generate it, instead of building without .pdb
s and then generating .pdb
files using cv2pdb after the fact...
@@ -3,7 +3,7 @@ | |||
_realname=cv2pdb | |||
pkgbase="mingw-w64-${_realname}" | |||
pkgname=("${MINGW_PACKAGE_PREFIX}-${_realname}") | |||
pkgver=0.50 | |||
pkgver=0.51.8.g9286b93 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to wait for a full release than to upgrade to an interim version.
Hmm. This looks as if the build wants to call @dennisameling would you mind cherry-picking 1c34c0d to see whether that fixes the build? |
The `mingw-w64-cv2pdb` build, for example, wants to be able to call `git tag`, which requires a user to be configured. Let's do that, then. Signed-off-by: Johannes Schindelin <[email protected]>
Thanks! That resulted in:
You might want to remove the |
This is no longer needed as I'm now using Clang's built-in functionality to generate PDBs in git-for-windows/MINGW-packages#56. Thanks for the suggestion! |
Needs rainers/cv2pdb#81 to add ARM64 support (merged ✅)
Tested with
MINGW_ARCH=clangarm64 makepkg-mingw -i
and things work as expected: