Add Windows ARM64 support #81
Conversation
|
The original purpose of cv2pdb is to translate old style CodeView debug information of the reference D compiler to pdb files. Later support for DWARF as emitted by the gcc based D compiler was added. The code in demangle.cpp is used to convert the mangled symbols of D functions or variables back to human readable form. It is unlikely to be useful for translating C++ debug information. The code failing to compile is inline assembly that converts 80-bit floating point real values to something the C++ compiler understands, namely 64-bit floating point. I doubt that you will need that on ARM, so if you replace the usage of |
|
Thanks for the hint! Have implemented the changes as you suggested. Here's a successful CI run: https://github.com/dennisameling/cv2pdb/actions/runs/3077972033 Curious to hear what you think! |
src/demangle.cpp
Outdated
|
|
||
| #include "symutil.h" | ||
|
|
||
| #ifdef _M_X64 | ||
| extern "C" void cvt80to64(void * in, long double * out); | ||
| #elif _M_ARM64 | ||
| void cvt80to64(void * in, long double * out) { | ||
| throw std::runtime_error("cvt80to64 is only supported on x64 processors."); |
There was a problem hiding this comment.
This produces a silent termination with msvc, so I'd prefer a printf + exit.
Otherwise looks good to me.
There was a problem hiding this comment.
Thanks. Have just implemented that. CI succeeded again.
The resulting binary also starts correctly:
C:\repos\cv2pdb\bin\Release_ARM64>.\cv2pdb --help
Convert DMD CodeView/DWARF debug information to PDB files, Version 0.52
Copyright (c) 2009-2012 by Rainer Schuetze, All Rights Reserved
License for redistribution is given by the Artistic License 2.0
see file LICENSE for further details
usage: --help [-D<version>|-C|-n|-e|-s<C>|-p<embedded-pdb>] <exe-file> [new-exe-file] [pdb-file]
|
Thank you for your contribution. |
This adds ARM64 support to the
cv2pdb.vcxprojbuild. Needed for Git for Windows ARM64 support.