feat(translation): add pt translation #440
Conversation
|
@Jpfonseca It's just Portuguese, right? If so, then leave just And please read the instruction for adding a new translation. Thanks in advance! |
|
@lex111 there are 2 types of portuguese : pt-pt and pt-br. That's why I kept the name of the file |
There was a problem hiding this comment.
Agreed, we already have Brazilian Portuguese so it only makes sense to specify the Portuguese variation :)
Thank you, this looks great to me. Feel free to do another pass through @lex111 and if it looks good let's merge this baby in
.all-contributorsrc
Outdated
| @@ -381,6 +381,13 @@ | |||
| "code", | |||
| "bug" | |||
| ] | |||
| }, | |||
| { | |||
| "login": "Jpfonseca", | |||
|
@Jpfonseca I understood, but the fact is that we change the original name of the locale, making it compatible with moment library, so we need the name of the locale to match the name of the locale in moment:
Therefore, please change the code with P.S. @housseindjirdeh how correctly to describe this in the instruction? |
|
@lex111 Sorry that i didn't do that before . |
| @@ -20,6 +20,11 @@ export default [ | |||
| name: 'Türkçe', | |||
| }, | |||
| { | |||
| code: 'pt-pt', | |||
andrewda
changed the title
|
Cheers thank you @lex111 and sorry I didn't realize that earlier. Added that step to our translations instructions. |
|
@lex111 I think you can merge it now .. |
|
@Jpfonseca No trouble at all! If anything, we need to apologize for not being super clear in the docs and having to tell you to change it up slghtly Thank you for this, really means a lot to take the time to get all the translations in ❤️ |
Added pt-pt as asked in #439 .