Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update nl.js #451

Merged
merged 1 commit into from
Oct 8, 2017
Merged

fix: update nl.js #451

merged 1 commit into from
Oct 8, 2017

Conversation

eliottha
Copy link
Contributor

@eliottha eliottha commented Oct 8, 2017

Updated the translations to more polite-form
Updated google-translate phrases
Updated incorrect tenses
Updated English tenses

@eliottha
Update nl.js
52a530f 
Updated the translations to more polite-form
Updated google-translate phrases
Updated incorrect tenses
Updated English tenses
@eliottha eliottha mentioned this pull request Oct 8, 2017
Open
lex111
lex111 approved these changes Oct 8, 2017
View reviewed changes
Copy link
Member

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@eliottha
Copy link
Contributor Author

eliottha commented Oct 8, 2017

Any idea when it will be merged?

@lex111
Copy link
Member

lex111 commented Oct 8, 2017

@Eliottiosdevs today or tomorrow, @housseindjirdeh will merge.

machour
machour approved these changes Oct 8, 2017
View reviewed changes
Copy link
Member

@machour machour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you sooo much for this @Eliottiosdevs!

housseindjirdeh
housseindjirdeh approved these changes Oct 8, 2017
View reviewed changes
Copy link
Member

@housseindjirdeh housseindjirdeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @Eliottiosdevs, please don't forget to add yourself as a contributor with yarn contributors:add! And welcome 🎉

@housseindjirdeh housseindjirdeh merged commit badb343 into gitpoint:master Oct 8, 2017
@andrewda andrewda changed the title Update nl.js fix: update nl.js Oct 8, 2017
@eliottha
Copy link
Contributor Author

eliottha commented Oct 8, 2017

Thanks @housseindjirdeh for merging!

@housseindjirdeh
Copy link
Member

Not at all, thank YOU for contributing my friend @Eliottiosdevs :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@housseindjirdeh housseindjirdeh housseindjirdeh approved these changes

@lex111 lex111 lex111 approved these changes

@machour machour machour approved these changes

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eliottha @lex111 @housseindjirdeh @machour