-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change default genesis package creator, and add way to configure it #2573
Comments
Needed:
This is the recommended course of action. Now, I'm exploring a way to have the equivalent of |
I've thought a lot about this and tried a few different implementations locally, so I finally reached a conclusion:
gnogenesis txs add packages --signer-key MainKey ...
EDIT:
|
Hello @zivkovicmilos about this, I saw that we already have some sort of 'fix' for this: On my PR I have started working on how to sign and verify the signature ( Issue related to verify signatures: #1104 ) And all the genesis generation was working. Also I was able to launch the chain locally (With sign verification on) Current PR #2986. Currently I'm using a Mnemonic, because I need a way to sign the TXs but I could also use a keyName some sort of what we do on maketx give a keyName and then ask for the key password ? Thanks what do you think ? |
closes gnolang#2573 Had to change the PR from a personal repository as the pipeline was failing old PR: gnolang#2986 <!-- please provide a detailed description of the changes made in this pull request. --> <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests </details> --------- Co-authored-by: 6h057 <[email protected]> Co-authored-by: Miloš Živković <[email protected]>
closes #2573 Had to change the PR from a personal repository as the pipeline was failing old PR: #2986 <!-- please provide a detailed description of the changes made in this pull request. --> <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests </details> --------- Co-authored-by: 6h057 <[email protected]> Co-authored-by: Miloš Živković <[email protected]>
#2508's genesis file contains all the packages in
examples/
initialized and deployed by the test1 key,g1jg8mtutu9khhfwc4nxmuhcpftf0pajdhfvsqf5
. This is probably fine, but the deployer of the genesis package shouldn't be one where the mnemonic is public and well-known; especially since I believe some packages in examples are giving special privileges to the deployer (through astd.PrevRealm().Addr()
/GetOrigCaller()
in initialization).Maybe we can have a deployer deployer address like
g1sh0uldn0thappen...
. :)We should change the default in
gno.land/cmd/gnoland/genesis_txs_add_packages.go
, but also add a way to configure it from the command line.The text was updated successfully, but these errors were encountered: