Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(genesis): deployerAddress passed as parameter #3253

Conversation

Villaquiranm
Copy link
Contributor

@Villaquiranm Villaquiranm commented Nov 30, 2024

closes #2573

Had to change the PR from a personal repository as the pipeline was failing
old PR: #2986

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests

@Gno2D2
Copy link
Collaborator

Gno2D2 commented Nov 30, 2024

I'm a bot that assists the Gno Core team in maintaining this repository. My role is to ensure that contributors understand and follow our guidelines, helping to streamline the development process.

The following requirements must be fulfilled before a pull request can be merged.
Some requirement checks are automated and can be verified by the CI, while others need manual verification by a staff member.

These requirements are defined in this configuration file.

Automated Checks

🟢 Maintainers must be able to edit this pull request
🟢 The pull request head branch must be up-to-date with its base

Manual Checks

No manual checks match this pull request.

Debug
Automated Checks
Maintainers must be able to edit this pull request

If

🟢 Condition met
└── 🟢 On every pull request

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

The pull request head branch must be up-to-date with its base

If

🟢 Condition met
└── 🟢 On every pull request

Then

🟢 Requirement satisfied
└── 🟢 Head branch (Villaquiranm:feat/configure-address-deployer-genesis) is up to date with base (master): behind by 0 / ahead by 30

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@Villaquiranm Villaquiranm marked this pull request as draft November 30, 2024 14:03
@Villaquiranm Villaquiranm changed the title Feat/configure address deployer genesis feat(genesis): deployerAddress passed as parameter Nov 30, 2024
@Villaquiranm Villaquiranm force-pushed the feat/configure-address-deployer-genesis branch from eda0800 to e3cd9b5 Compare December 1, 2024 16:38
@Villaquiranm Villaquiranm force-pushed the feat/configure-address-deployer-genesis branch from e3cd9b5 to 9398edd Compare December 1, 2024 16:39
@Villaquiranm Villaquiranm marked this pull request as ready for review December 2, 2024 16:54
@notJoon notJoon added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Dec 3, 2024
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

I've left a few nitpicks, otherwise we are good to go 👍

We will need to change this functionality when / if we merge #3213

cc @Kouteki I'll open a new issue when #3213 is decided

contribs/gnogenesis/internal/txs/txs_add_packages.go Outdated Show resolved Hide resolved
contribs/gnogenesis/internal/txs/txs_add_packages.go Outdated Show resolved Hide resolved
@Villaquiranm
Copy link
Contributor Author

Looks good 💯

I've left a few nitpicks, otherwise we are good to go 👍

We will need to change this functionality when / if we merge #3213

cc @Kouteki I'll open a new issue when #3213 is decided

Thanks for the review 🚀
I'll gladly tackle this if neccessary

@zivkovicmilos
Copy link
Member

@Villaquiranm

Can you please unexport the deployerAddress field from the cfg struct, and make the defaultCreat a package global?
var defaultCreator = crypto.MustAddressFromString(...)

@Villaquiranm
Copy link
Contributor Author

@Villaquiranm

Can you please unexport the deployerAddress field from the cfg struct, and make the defaultCreat a package global? var defaultCreator = crypto.MustAddressFromString(...)

@zivkovicmilos
Sorry I misunderstood you
changed here: 051cbd5

@jefft0 jefft0 removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Dec 3, 2024
@jefft0
Copy link
Contributor

jefft0 commented Dec 3, 2024

Removed the review/triage-pending label because this PR was reviewed by core dev zivkovicmilos.

@zivkovicmilos zivkovicmilos added the don't merge Please don't merge this functionality temporarily label Dec 3, 2024
@zivkovicmilos zivkovicmilos removed the don't merge Please don't merge this functionality temporarily label Dec 3, 2024
@zivkovicmilos zivkovicmilos merged commit 78f0e20 into gnolang:master Dec 4, 2024
103 of 105 checks passed
r3v4s pushed a commit to gnoswap-labs/gno that referenced this pull request Dec 10, 2024
closes gnolang#2573

Had to change the PR from a personal repository as the pipeline was
failing
old PR: gnolang#2986
<!-- please provide a detailed description of the changes made in this
pull request. -->

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
</details>

---------

Co-authored-by: 6h057 <[email protected]>
Co-authored-by: Miloš Živković <[email protected]>
@Kouteki Kouteki removed the in focus label Dec 16, 2024
albttx pushed a commit that referenced this pull request Jan 10, 2025
closes #2573

Had to change the PR from a personal repository as the pipeline was
failing
old PR: #2986
<!-- please provide a detailed description of the changes made in this
pull request. -->

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
</details>

---------

Co-authored-by: 6h057 <[email protected]>
Co-authored-by: Miloš Živković <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

change default genesis package creator, and add way to configure it
6 participants