Cannot change milestone or assignee in 1.1 #1271

flomine · 2017-03-15T22:12:00Z

Gitea version (or commit ref): 1.1.0
Git version: 2.1.4
Operating system: Debian GNU/Linux 8
Database (use [x]):
- PostgreSQL
- MySQL (MariaDB)
- MSSQL
- SQLite
Can you reproduce the bug at https://try.gitea.io:
https://try.gitea.io seems offline. It returns 404
Log gist:

Description

Since update from 1.0.2 to 1.1.0, I cannot change (or assign) any milestone to any issue.
It goes back to the previous state. Nevertheless it works for labels. Same problem for assignee.
I don't have anything in log file.
How can I investigate ?

The text was updated successfully, but these errors were encountered:

lunny · 2017-03-16T00:59:51Z

I have tested on https://try.gitea.io, I can change them, but maybe it's web browser refresh problem?

flomine · 2017-03-16T09:20:20Z

I try on try.gitea.io and I have the same problem (repo test-bug for user flomine).
So this seems to be related to my browser. It worked well before the update to 1.1
My browser is firefox 52 (64 bits) linux version. I will try another one.

flomine · 2017-03-16T09:54:35Z

I did all my tests on try.gitea.io
It is clearly a problem with firefox because it works well with chromium.

I deactivated all modules in firefox and restart firefox -> same problem

I clear firefox cache -> It works at the begining then it starts to have this refreshment problem. But the difference is that now it works 1 time on 5 or 6 times milestone changes.
It seems to be related with the new feature that displays changes about milestones or assignee in the history of a repo. When I assign a milestone, the history changes then it goes back to the previous state.

I also tried with Firefox 51.0.1 on windows 7. I also notice this bug but it seems to appear less often.
One time over 10 milestone changes approximately

On chromium, I tried more than 10 times and I never experienced this problem.

I don't know if is is related but after emptied firefox's cache, it gave me error 500.

jhasse · 2017-03-17T13:49:05Z

Shouldn't the milestone be 1.1.x? It's quite a critical regression IMHO.

pgaskin · 2017-03-17T13:51:31Z

My test server is working fine. https://staging.geek1011.net

The only difference is I have applied the openid patch.

lunny · 2017-03-18T02:01:50Z

It will be backport v1.1.x. All bugs should be fixed in v1.2 and backport if needed to stable versions.

bkcsoft · 2017-03-20T01:06:23Z

Added the backport-label :)

bkcsoft · 2017-03-20T01:09:00Z

Interesting, it works fine in Chrome, but not in Firefox 😂

lunny · 2017-05-31T01:15:22Z

fixed by #1728

flomine · 2017-06-09T09:42:06Z

I update to last version (4a3f404) and I still have the issue. I tried to clear cache.. Still the same :-(

flomine · 2017-06-09T09:50:25Z

How can I help to give more info about this issue ?

lunny · 2017-06-09T13:33:30Z

@flomine could you make some repos or issues which will fail on https://try.gitea.io and paste the link here?

flomine · 2017-06-09T13:49:13Z

here the issue to test. I cannot set a milestone with firefox.
https://try.gitea.io/flomine2/test-_1271/issues/1

flomine · 2017-06-09T13:50:43Z

Same problem for Assignee. But it works for label.

lunny · 2017-06-09T14:48:44Z

But have tried https://try.gitea.io/flomine2/test-_1271/issues/1 it works well on firefox on macOS

flomine · 2017-06-09T15:28:06Z

it works with firefox on windows 7 but not with firefox on linux(52.1.0 ESR 64bits or 53.0.3 64bits both on archlinux) . It works with chromium on linux.
So compared to my first report, it is better since it is now working on windows. But it is still a problem for me.

flomine · 2017-06-14T09:23:15Z

So actually here are my test results:
bug present with firefox 53.0.3 (64 bits) under ubuntu 16.04
bug present with firefox 53.0.3 (64 bits) under archlinux
bug present with firefox ESR 52.1.0 (64 bits) under archlinux
no bug with chromium under archlinux
no bug with firefox under android
no bug with firefox under Win7 (since #1728)

sapk · 2017-06-14T13:04:39Z

Do you have any error in your browser console ? (Ctrl + Shift + K on firefox)

flomine · 2017-06-14T13:24:25Z

only css errors and warnings.
See here https://privatebin.net/?15cafca1ebcd7968#YwjWymVh9iAlj9krt5wReDPhHguf4aYEhU7li+mkiuM=

lafriks · 2017-06-14T15:18:16Z

If you open labels/milestones setting page does it show correctly or do you get 404 page? I have such situation for migrated gogs to gitea server. And then also labels/milestones/assignees can not be changed.

flomine · 2017-06-14T15:23:38Z

no everything is ok on setting page. No 404 page.
My server (migration from gogs to gitea) has this bug.
Nevertheless, the bug is also present here https://try.gitea.io/flomine2/test-_1271/issues/1

schmittlauch · 2017-06-21T07:58:51Z

@flomine Which add-ons do you have installed? In #2021 I found Disconnect, PrivacyBadger, and FoxyProxy Standard Edition to cause this issue.

flomine · 2017-06-21T09:27:22Z

before #1728, bug was present under windows and Linux even without Firefox add-ons.
But now it is quite different (maybe not exactly the same bug). Indeed, if I deactivate Ghostery add-on, the bug disappers and sometimes leads to a 404 or 500 page.

schmittlauch · 2017-06-21T11:19:31Z

Apparently the POST request to /user/repo/issues/1/assignee is never made with one of the add-ons enabled.

It'd be great if someone with better JS frontend debugging skills could take a look how the control flow differs with an add-on enabled vs. an add-on disabled. The issue is really easy to reproduce, just look at the particular add-on issues linking to #2021.

bkcsoft · 2017-06-26T22:19:03Z

Running Fx 54.0. Disabling PB and Social Disconnect does not fix this issue 🙄

schmittlauch · 2017-06-26T22:51:30Z

@bkcsoft Can you try again using a new Firefox profile (e.g. by using firefox --ProfileManager)?
If the issue doesn't appear in a fresh Firefox profile, you have to try out which of your normal addons causes this by deactivating all but one at a time. If the cause is a bug in Firefox's addon system itself, it's not unlikely that other addons can also cause this issue.

bkcsoft · 2017-06-26T22:53:46Z

~~Well, I found the issue actually... It's a code issue, not a plugin issue :)~~

~~https://github.com/go-gitea/gitea/blob/master/public/js/index.js#L207 and https://github.com/go-gitea/gitea/blob/master/public/js/index.js#L233 aren't setting an appropriate action 🙄~~

EDIT: not it 🙄

schmittlauch · 2017-06-26T22:57:59Z

If this fixes the issue - great. Nevertheless I ask myself why this issue didn't appear without certain addons being enabled and whether that's a valid behaviour (comparable to the old-days quirks mode)

schmittlauch · 2017-06-26T23:17:10Z

@bkcsoft As you seem to be much fitter than I in frontend JS debugging, can you find out how the control flow/ code path differs in a fresh profile (given the issue doesn't appear there) and in a profile where this issue appears?
This can be very useful for add-on developers.

bkcsoft · 2017-06-26T23:46:13Z

Well, it's a code-issue, it reloaded the page before it POSTed 😂 https://gist.github.com/bkcsoft/4b655d32f969ff905926bfedfb5f6f97 <-- patch

Buuut now I have to press "unassign" twice because the first time it throws a 500 error 😂 https://gist.github.com/bkcsoft/e934aacc064fb767a304db53da2ea128 <-- errorlog

schmittlauch · 2017-06-27T00:03:03Z

In a Firefox with a fresh profile or when using Chromium, the XML http request changing the assignment is sent but the script doesn't wait for a response and just reloads the page, nevertheless having changed the assignment.
With a "bad" addon active the XHR is never sent though.

it reloaded the page before it POSTed

So at least in the "working" condition that's not true. It sends the POST XHR but doesn't wait for the response and instead reloads. (Still weird behaviour IMHO)

knixeur · 2017-06-28T03:14:36Z

As @schmittlauch said this is because XHR is not finished before page reloads.
It works fine on Chrome, not on Firefox for me, and I bet it's not directly related to any plugin but to how events are handled and race conditions.
You can easily test this by settings a break point at index.js line 194 https://github.com/go-gitea/gitea/blob/master/public/js/index.js#L194
When that breakpoint is hit, you give Firefox enough time to complete the request and "it works".

I was reviewing the code and as function selectItem is only used for milestone and assigned the code could be changed to do a location.reload after issuing a updateIssuesMeta by sending an afterSuccess call back.
~~That location.reload is called from https://github.com/go-gitea/gitea/blob/master/public/js/index.js#L222~~ the event is trigged when the dropdown is hidden https://semantic-ui.com/modules/dropdown.html#/settings onHide https://github.com/go-gitea/gitea/blob/master/public/js/index.js#L192

location.reload was being called when the related dropdown was hidden, even if a request initiated before to update this value hadn't finished. This caused troubles on Firefox.

UziTech · 2017-09-28T22:00:38Z

I'm running into this issue on v1.2.0-rc3 and https://try.gitea.io

The first time I try to change the assignee it gives a 500 error. If I click on the same assignee again it works.

Version 62.0.3202.29 (Official Build) beta (64-bit)
Windows 10 Pro Build 16296.rs3

flomine changed the title ~~Cannot change milestone in 1.1~~ Cannot change milestone or assignee in 1.1 Mar 15, 2017

lunny added the type/bug label Mar 16, 2017

lunny added this to the 1.2.0 milestone Mar 16, 2017

lunny added the topic/ui Change the appearance of the Gitea UI label Mar 16, 2017

bkcsoft added the backport/v1.1 label Mar 20, 2017

strk mentioned this issue Apr 30, 2017

Unit tests for issue_milestone #878

Merged

lunny mentioned this issue May 18, 2017

Fix FOUC on Firefox #1728

Merged

lunny closed this as completed May 31, 2017

lunny reopened this Jun 9, 2017

sondr3 mentioned this issue Jun 21, 2017

Can't assign users to issues #2021

Closed

7 tasks

lunny mentioned this issue Jun 28, 2017

Fix #1271: Call location.reload after XHR finishes #2071

Merged

lunny closed this as completed in 858197b Jun 28, 2017

go-gitea locked and limited conversation to collaborators Nov 23, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cannot change milestone or assignee in 1.1 #1271

Cannot change milestone or assignee in 1.1 #1271

flomine commented Mar 15, 2017 •

edited

Loading

lunny commented Mar 16, 2017

flomine commented Mar 16, 2017

flomine commented Mar 16, 2017 •

edited

Loading

jhasse commented Mar 17, 2017

pgaskin commented Mar 17, 2017 •

edited

Loading

lunny commented Mar 18, 2017

bkcsoft commented Mar 20, 2017

bkcsoft commented Mar 20, 2017

lunny commented May 31, 2017

flomine commented Jun 9, 2017

flomine commented Jun 9, 2017

lunny commented Jun 9, 2017

flomine commented Jun 9, 2017 •

edited

Loading

flomine commented Jun 9, 2017

lunny commented Jun 9, 2017

flomine commented Jun 9, 2017

flomine commented Jun 14, 2017

sapk commented Jun 14, 2017

flomine commented Jun 14, 2017

lafriks commented Jun 14, 2017

flomine commented Jun 14, 2017

schmittlauch commented Jun 21, 2017 •

edited

Loading

flomine commented Jun 21, 2017

schmittlauch commented Jun 21, 2017

bkcsoft commented Jun 26, 2017

schmittlauch commented Jun 26, 2017

bkcsoft commented Jun 26, 2017 •

edited

Loading

schmittlauch commented Jun 26, 2017

schmittlauch commented Jun 26, 2017

bkcsoft commented Jun 26, 2017

schmittlauch commented Jun 27, 2017 •

edited

Loading

knixeur commented Jun 28, 2017 •

edited

Loading

UziTech commented Sep 28, 2017

Cannot change milestone or assignee in 1.1 #1271

Cannot change milestone or assignee in 1.1 #1271

Comments

flomine commented Mar 15, 2017 • edited Loading

Description

lunny commented Mar 16, 2017

flomine commented Mar 16, 2017

flomine commented Mar 16, 2017 • edited Loading

jhasse commented Mar 17, 2017

pgaskin commented Mar 17, 2017 • edited Loading

lunny commented Mar 18, 2017

bkcsoft commented Mar 20, 2017

bkcsoft commented Mar 20, 2017

lunny commented May 31, 2017

flomine commented Jun 9, 2017

flomine commented Jun 9, 2017

lunny commented Jun 9, 2017

flomine commented Jun 9, 2017 • edited Loading

flomine commented Jun 9, 2017

lunny commented Jun 9, 2017

flomine commented Jun 9, 2017

flomine commented Jun 14, 2017

sapk commented Jun 14, 2017

flomine commented Jun 14, 2017

lafriks commented Jun 14, 2017

flomine commented Jun 14, 2017

schmittlauch commented Jun 21, 2017 • edited Loading

flomine commented Jun 21, 2017

schmittlauch commented Jun 21, 2017

bkcsoft commented Jun 26, 2017

schmittlauch commented Jun 26, 2017

bkcsoft commented Jun 26, 2017 • edited Loading

schmittlauch commented Jun 26, 2017

schmittlauch commented Jun 26, 2017

bkcsoft commented Jun 26, 2017

schmittlauch commented Jun 27, 2017 • edited Loading

knixeur commented Jun 28, 2017 • edited Loading

UziTech commented Sep 28, 2017

flomine commented Mar 15, 2017 •

edited

Loading

flomine commented Mar 16, 2017 •

edited

Loading

pgaskin commented Mar 17, 2017 •

edited

Loading

flomine commented Jun 9, 2017 •

edited

Loading

schmittlauch commented Jun 21, 2017 •

edited

Loading

bkcsoft commented Jun 26, 2017 •

edited

Loading

schmittlauch commented Jun 27, 2017 •

edited

Loading

knixeur commented Jun 28, 2017 •

edited

Loading