Fix #1271: Call location.reload after XHR finishes #2071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
location.reload was being called when the related dropdown was hidden, even if a request initiated before to update this value hadn't finished. This caused troubles on Firefox.
|
Great. LGTM will fix #1271. Thanks! |
tboerger
added
the
lgtm/need 1
|
This should probably be reworked in 1.3 not to reload page at all but otherwise LGTM |
tboerger
added
lgtm/done
|
@lafriks let's merge this at first. |
|
@lunny yes, of course, that should be other PR after 1.2.0 is released |
|
It seems this PR is difficult to back ported to v1.1. I have gave up this. |
|
@lunny Have you checked that this needs doing on v1.1.3? |
|
Yes, v1.1.4 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
location.reload was being called when the related dropdown
was hidden, even if a request initiated before to update this
value hadn't finished. This caused troubles on Firefox.
Please check the following:
masterbranch, pull requests on release branches are only allowed for bug fixes.You MUST delete the content above including this line before posting, otherwise your pull request will be invalid.