Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting container images is non-deterministic #25559

Open
delvh opened this issue Jun 28, 2023 · 5 comments
Open

Deleting container images is non-deterministic #25559

delvh opened this issue Jun 28, 2023 · 5 comments
Labels
topic/packages topic/ui-interaction Change the process how users use Gitea instead of the visual appearance

Comments

@delvh
Copy link
Member

delvh commented Jun 28, 2023

Description

At the moment, it is only somewhat possible to delete container packages:
When you come from the org packages tab and click on delete for any package, you simply get redirected to the org page listing all packages.
When you come from the repo packages tab, there is a chance of about 50-60% that you will get the same behavior as with the org packages tab.
However, after trying about three to four times per package, I was finally able to delete one.

Gitea Version

1.19.3

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

Nothing. I mean, we only set the log level to WARNING, but apart from a lot of (somewhat) unrelated 2023/06/28 11:23:44 ...les/cache/context.go:71:SetContextData() [W] [649bfc20] cannot get cache context when setting data: *db.Context.WithValue(type struct {}, val NotifyPackageDelete) messages, there was nothing.

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

From binary.

Database

SQLite

@delvh delvh added the type/bug label Jun 28, 2023
@KN4CK3R
Copy link
Member

KN4CK3R commented Jun 29, 2023

There may be a misunderstanding. You only delete a package version from the ui. If there are multiple versions the package is still there and you can view it from the package list. It may be better to redirect to the package again if there is still another version than the redirect to the package list after the delete.

@delvh
Copy link
Member Author

delvh commented Jun 29, 2023

Okay, if that's the case, then we should probably indicate that you only delete the latest version by "deleting the package".
Or alternatively add a delete all versions button.

@KN4CK3R
Copy link
Member

KN4CK3R commented Jun 29, 2023

No, not the latest version. You delete the version you are looking at. The version is mentioned in popup:
grafik

But yes, this area should mention "version" somewhere:
grafik

@KN4CK3R KN4CK3R added topic/ui-interaction Change the process how users use Gitea instead of the visual appearance topic/packages and removed type/bug labels Jun 29, 2023
silverwind pushed a commit that referenced this issue Jun 29, 2023
Related #25559

Current behaviour:
1. Deletion of a package version
2. Redirect to the owners package list

New behaviour:
1. Deletion of a package version
2.1. If there are more versions available, redirect to the package again
2.2. If there are no versions available, redirect to the owners package
list
KN4CK3R added a commit to KN4CK3R/gitea that referenced this issue Jun 29, 2023
Related go-gitea#25559

Current behaviour:
1. Deletion of a package version
2. Redirect to the owners package list

New behaviour:
1. Deletion of a package version
2.1. If there are more versions available, redirect to the package again
2.2. If there are no versions available, redirect to the owners package
list
silverwind pushed a commit that referenced this issue Jun 29, 2023
Related #25559

Current behaviour:
1. Deletion of a package version
2. Redirect to the owners package list

New behaviour:
1. Deletion of a package version
2.1. If there are more versions available, redirect to the package again
2.2. If there are no versions available, redirect to the owners package
list
@lonix1
Copy link
Contributor

lonix1 commented Aug 1, 2023

As shown in my dupe issue, the wording needs some work.

I was apprehensive to click that button because I assumed it would delete the entire package, instead of just a specific version. Since I never clicked the button, I never saw the wording shown in the image above, and assumed it's not possible to delete a specific version.

@lonix1
Copy link
Contributor

lonix1 commented Aug 1, 2023

Probably too late to add more ideas, but what would be the best UX is to have a small delete button next to each version, on the "view all" versions page: https://gitea.example.com/org/-/packages/container/repo/versions.

EDIT:
Nah, it should be hard to delete a version. The current page is ok. Just the wording should be improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/packages topic/ui-interaction Change the process how users use Gitea instead of the visual appearance
Projects
None yet
Development

No branches or pull requests

3 participants