Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

css bug in /$org/-/packages/container/$foo/latest/settings #26310

Closed
bf opened this issue Aug 3, 2023 · 5 comments · Fixed by #26314
Closed

css bug in /$org/-/packages/container/$foo/latest/settings #26310

bf opened this issue Aug 3, 2023 · 5 comments · Fixed by #26314
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@bf
Copy link

bf commented Aug 3, 2023

Description

go to: /$org/-/packages/container/$foo/latest/settings to see that the css is broken

open your organization page -> packages -> select package -> click on settings in bottom right corner -> see broken red box

Screenshots

image

Gitea Version

1.21.0+dev-437-gb9baed2c74

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

arch

Browser Version

chrome
@bf bf added type/bug topic/ui Change the appearance of the Gitea UI labels Aug 3, 2023
@KN4CK3R
Copy link
Member

KN4CK3R commented Aug 3, 2023

Must be a regression, was fine a month ago

@bf
Copy link
Author

bf commented Aug 3, 2023

Seems to me the <div class='item'> should be removed

image

@bf
Copy link
Author

bf commented Aug 3, 2023

Just updated to 1.21.0+dev-450-g0827fbd49c and css bug still present

@bf
Copy link
Author

bf commented Aug 3, 2023

This line needs to be changed. Not sure if CSS class item is needed for the ui-right part:
https://github.com/go-gitea/gitea/blob/main/templates/package/settings.tmpl#L42C3-L42C22

@KN4CK3R
Copy link
Member

KN4CK3R commented Aug 3, 2023

It's a regression of #25790. I will send a fix PR.

@KN4CK3R KN4CK3R mentioned this issue Aug 3, 2023
Merged
silverwind pushed a commit that referenced this issue Aug 8, 2023
@KN4CK3R @GiteaBot
Use flex classes in package settings (#26314)
e6f8e93 
Regression of #25790
Fixes #26310

---------

Co-authored-by: Giteabot <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use flex classes in package settings KN4CK3R/gitea
2 participants
@bf @KN4CK3R