Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not readable style #25939

Closed
somera opened this issue Jul 17, 2023 · 19 comments · Fixed by #26713 or #29581
Closed

Not readable style #25939

somera opened this issue Jul 17, 2023 · 19 comments · Fixed by #26713 or #29581
Assignees
@denyskon
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Milestone
1.23.0

Comments

@somera
Copy link

somera commented Jul 17, 2023

Description

The new style is so compact, that the table is not readable.

I would say, that the ID column is not needed.

Screenshots

image

image

Gitea Version

1.20.0

Can you reproduce the bug on the Gitea demo site?

No

Operating System

Ubuntu 20.04.4

Browser Version

Chrome
@somera somera added type/bug topic/ui Change the appearance of the Gitea UI labels Jul 17, 2023
@somera
Copy link
Author

somera commented Jul 17, 2023

This ist the old style.
image
You can read the content in the table better.

@KazzmanK
Copy link
Contributor

For such a request it may be sufficient to make left pane be collapsible under hamburger menu.

@silverwind
Copy link
Member

This was #25568. Could maybe increase horizontal padding by like 1-2px, but I wouldn't do more.

@KN4CK3R
Copy link
Member

KN4CK3R commented Jul 18, 2023

Maybe we could drop some columns like Beobachtungen as they are not really relevant in the admin context.

@somera
Copy link
Author

somera commented Jul 18, 2023 •
edited
Loading

@KN4CK3R I would say this columns
image
are not so important in this view.

@denyskon
Copy link
Member

denyskon commented Jul 18, 2023 •
edited
Loading

Maybe we should make a separate page with user details to move stuff out of the table

@lunny
Copy link
Member

lunny commented Jul 19, 2023

Group the numbers columns as 1 column if they are not sortable columns.

@somera
Copy link
Author

somera commented Jul 19, 2023

I checked the whole new UI and I'm not so happy with mowing the navigation to the left size. When you will extend the table size to WQHD, than it will look better. But the compressend width is not good. Sorry, this was wrong UI change.

@denyskon
Copy link
Member

Regardless of the navigation, I think we need to simplify these tables.

@somera
Copy link
Author

somera commented Jul 19, 2023

But you have to fix all tables.

image

image

image

silverwind added a commit to silverwind/gitea that referenced this issue Jul 21, 2023
@silverwind
Increase table cell padding, use icons in admin table headers
db8b488 
Fixes: go-gitea#25939
@silverwind silverwind mentioned this issue Jul 21, 2023
Closed
@denyskon denyskon mentioned this issue Aug 24, 2023
Merged
@lunny
Copy link
Member

lunny commented Aug 28, 2023

The width of admin page could be extended like code review pages.

silverwind pushed a commit that referenced this issue Aug 31, 2023
@denyskon @GiteaBot
User details page (#26713)
5b5bb8d 
This PR implements a proposal to clean up the admin users table by
moving some information out to a separate user details page (which also
displays some additional information).

Other changes:
- move edit user page from `/admin/users/{id}` to
`/admin/users/{id}/edit` -> `/admin/users/{id}` now shows the user
details page
- show if user is instance administrator as a label instead of a
separate column
- separate explore users template into a page- and a shared one, to make
it possible to use it on the user details page
- fix issue where there was no margin between alert message and
following content on admin pages

<details>

<summary>Screenshots</summary>


![grafik](https://github.com/go-gitea/gitea/assets/47871822/1ad57ac9-f20a-45a4-8477-ffe572a41e9e)


![grafik](https://github.com/go-gitea/gitea/assets/47871822/25786ecd-cb9d-4c92-90f4-e7f4292c073b)


</details>

Partially resolves #25939

---------

Co-authored-by: Giteabot <[email protected]>
@denyskon denyskon reopened this Aug 31, 2023
@denyskon
Copy link
Member

Also needed for at least repo list

@silverwind
Copy link
Member

silverwind commented Aug 31, 2023 •
edited
Loading

Yes I suppose it could be made flexible full width, but still that's just a workaround that does not help on small screens.

@denyskon denyskon self-assigned this Oct 27, 2023
@denyskon denyskon added this to the 1.22.0 milestone Oct 27, 2023
@lunny lunny mentioned this issue Mar 4, 2024
Merged
lunny added a commit that referenced this issue Mar 4, 2024
@lunny
Make admin pages wider because of left sidebar added and some tables …
fad2320 
…become too narrow (#29581)

Fix #25939

screenshots 

<img width="1895" alt="image"
src="https://github.com/go-gitea/gitea/assets/81045/937eb28d-bb7d-4765-b580-bc991d61f467">
@denyskon denyskon reopened this Mar 4, 2024
@denyskon
Copy link
Member

denyskon commented Mar 4, 2024

Reopening, because org and repo details can still be moved out to separate pages

@lunny
Copy link
Member

lunny commented Apr 8, 2024

I think the UI problem mentioned in this issue has been resolved. So I will move this issue to another milestone.

@lunny lunny modified the milestones: 1.22.0, 1.23.0 Apr 8, 2024
@somera
Copy link
Author

somera commented Apr 13, 2024 •
edited
Loading

I think the UI problem mentioned in this issue has been resolved. So I will move this issue to another milestone.

Gitea version 1.21.10

There are a few small improvements. But it's not "perfect".

Sorted by size
image

Sorted by name
image

Date should be in one line. And the repo size.

@lunny
Copy link
Member

lunny commented Apr 14, 2024

#29581 hasn't been backport to v1.21

@lunny
Copy link
Member

lunny commented Sep 20, 2024

@somera Can you confirm v1.22 still have the problem?

@somera
Copy link
Author

somera commented Sep 20, 2024

I checked it with 1.22.2 and it looks good.

@lunny lunny closed this as completed Sep 20, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@denyskon denyskon

Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.23.0
6 participants
@lunny @silverwind @KN4CK3R @somera @KazzmanK @denyskon