auth/pam test fails with v1.23.0

[Antiz96]

Description

Hi,

When building Gitea 1.23.0, the auth/pam test is failing when running make test:

[...]
modules/auth/pam/pam_test.go:18:16: not enough arguments in call to assert.Len
[...]
FAIL    code.gitea.io/gitea/modules/auth/pam [build failed]
[...]
FAIL
make: *** [Makefile:473: test-backend] Error 1

It passes fine when building previous versions however (e.g. 1.22.6).

• Full build logs
• Full test logs

The build and test instructions we use are available here.

I remain available if needed :)

Gitea Version

1.23.0

Can you reproduce the bug on the Gitea demo site?

N/A

Log Gist

Provided in the description

Screenshots

N/A

Git Version

The build and test env is using git 2.47.1

Operating System

Arch Linux

How are you running Gitea?

N/A

Database

N/A

[TheFox0x7]

my bad, not sure how it didn't trigger any lint issues.

Is pam test not run in CI?

[Antiz96]

my bad, not sure how it didn't trigger any lint issues.

No problem, thanks for the very quick actions! 🙏
I can confirm the fix provided in #33169 fixes the issue 😄

[wxiaoguang]

Is pam test not run in CI?

Hmm .... it seems that pam test doesn't run in CI because there is no pam build tag.