Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pam auth test regression #33169

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Fix pam auth test regression #33169

merged 1 commit into from
Jan 9, 2025
+1 −1

Conversation

TheFox0x7
Copy link
Contributor

fixes: #33168

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 9, 2025
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 9, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jan 9, 2025
@TheFox0x7 TheFox0x7 changed the title fix pam auth regression fix pam auth test regression Jan 9, 2025
@Antiz96 Antiz96 mentioned this pull request Jan 9, 2025
Closed
@Antiz96
Copy link

Antiz96 commented Jan 9, 2025

Can confirm it fixes the issue, thanks!

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 9, 2025
@yp05327
Copy link
Contributor

yp05327 commented Jan 9, 2025 •
edited
Loading

For review more quickly:
releated changes:
https://github.com/go-gitea/gitea/pull/32852/files#diff-4492dcaa6518b722677a97e684650a4df1bf56130504ff9384c4f5effb82f5daL18-R18

ps: I can not understand why CI didn't failed?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 9, 2025
@yp05327 yp05327 changed the title fix pam auth test regression Fix pam auth test regression Jan 9, 2025
@wxiaoguang wxiaoguang added the backport/v1.23 This PR should be backported to Gitea 1.23 label Jan 9, 2025
@yp05327
Copy link
Contributor

yp05327 commented Jan 9, 2025 •
edited
Loading

Is this correct?
(In the origin PR)
https://github.com/go-gitea/gitea/actions/runs/12337937712/job/34432298985#step:8:57
image
In this PR, it is same

If I run it in local:

Running tool: /usr/local/go/bin/go test -timeout 30s -tags 'sqlite sqlite_unlock_notify' -run ^TestPamAuth$ code.gitea.io/gitea/modules/auth/pam -v

? code.gitea.io/gitea/modules/auth/pam [no test files]

Updated:
It seems that it needs build with "pam" tag, or it will not be tested.

image

But the test tag is not contained, that's why it was not noticed.

@wxiaoguang wxiaoguang merged commit 68ca73b into go-gitea:main Jan 9, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Jan 9, 2025
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jan 9, 2025
@TheFox0x7 @GiteaBot
Fix pam auth test regression (go-gitea#33169)
7125cad 
fixes: go-gitea#33168
@GiteaBot GiteaBot mentioned this pull request Jan 9, 2025
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Jan 9, 2025
wxiaoguang pushed a commit that referenced this pull request Jan 9, 2025
@GiteaBot @TheFox0x7
Fix pam auth test regression (#33169) (#33174)
d65af69 
Backport #33169 by TheFox0x7

fixes: #33168

Co-authored-by: TheFox0x7 <[email protected]>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 10, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
9e7866c 
* giteaofficial/main:
  Fix raw file API ref handling (go-gitea#33172)
  [skip ci] Updated translations via Crowdin
  Fix ACME panic (go-gitea#33178)
  Automerge supports deleting branch automatically after merging (go-gitea#32343)
  Fix branch dropdown not display ref name (go-gitea#33159)
  Add .run to gitignore (go-gitea#33175)
  Fix assignee list overlapping in Issue sidebar (go-gitea#33176)
  Fix pam auth test regression (go-gitea#33169)
  Move repo size to sidebar (go-gitea#33155)
  Fix fuzz test (go-gitea#33156)
  Refactor older tests to use testify (go-gitea#33140)
  [skip ci] Updated translations via Crowdin
  Fix typo in gitea downloader test and add missing codebase in `ToGitServiceType` (go-gitea#33146)
  Fix form width (go-gitea#33151)
  Convert github.com/xanzy/go-gitlab into gitlab.com/gitlab-org/api/client-go (go-gitea#33126)
  Refactor HTMLFormat, update chroma render, fix js error (go-gitea#33136)
  Add missed transaction on setmerged (go-gitea#33079)
@TheFox0x7 TheFox0x7 deleted the fix-assert-regression branch January 11, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yp05327 yp05327 yp05327 approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.23 This PR should be backported to Gitea 1.23 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

auth/pam test fails with v1.23.0
5 participants
@TheFox0x7 @Antiz96 @yp05327 @wxiaoguang @GiteaBot