Turn on GOPROXY in Drone #10960
Closed
Turn on GOPROXY in Drone #10960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jolheiser <[email protected]>
jolheiser
added
the
topic/build
jolheiser
added
the
status/blocked
|
I’m not 100% sure of this, but I’m pretty sure some of the reason why goproxy is off because we want to ensure to network connections and it isn’t covering up any missing items from go mod file. Now that we are on a version that fully supports go modules and have vendored (sp?) our tools we might even be able to disable go modules in more places (except for vendor check of course). |
GiteaBot
added
the
lgtm/need 2
|
Yes, it seems this still returns some errors with xgo anyways, so until we come up with a better solution I will close this. 😅 |
|
@jolheiser can you tell if the problem with xgo was techknowlogick/xgo#16? |
|
It's been a little while so I can't remember the specifics, but that looks similar. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
GOPROXYoff it seems some targets fail because they need go modules.This is a quick search/replace to point all
GOPROXYtohttps://goproxy.cnas we have it elsewhere in the Drone file already.I am unsure whether this is particularly necessary or if there is another/better way to do it.
Feel free to supersede this PR if that is the case.