Turn off go modules for xgo and gxz #10963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jolheiser <[email protected]>
jolheiser
added
the
topic/build
Signed-off-by: jolheiser <[email protected]>
|
@techknowlogick The error looks like the one we were discussing earlier this week, but I can't remember how/if we "fixed" it. |
GiteaBot
added
the
lgtm/need 2
|
@jolheiser If you find out let me know - need this for tea too ;) |
|
I ever did that with |
Signed-off-by: jolheiser <[email protected]>
Signed-off-by: jolheiser <[email protected]>
Signed-off-by: jolheiser <[email protected]>
Signed-off-by: jolheiser <[email protected]>
Signed-off-by: jolheiser <[email protected]>
Signed-off-by: jolheiser <[email protected]>
mrsdizzie
approved these changes
Apr 6, 2020
GiteaBot
added
lgtm/need 1
jolheiser
commented
Apr 6, 2020
| @@ -533,7 +533,7 @@ release-check: | $(DIST_DIRS) | |||
| .PHONY: release-compress | |||
| release-compress: | $(DIST_DIRS) | |||
| @hash gxz > /dev/null 2>&1; if [ $$? -ne 0 ]; then \ | |||
| $(GO) get -u github.com/ulikunitz/xz/cmd/gxz; \ | |||
| GO111MODULE=off $(GO) get -u github.com/ulikunitz/xz/cmd/gxz; \ | |||
There was a problem hiding this comment.
This is the only change I'm unsure of.
@techknowlogick Thoughts?
lunny
approved these changes
Apr 6, 2020
GiteaBot
added
lgtm/done
|
@jolheiser @lunny added this to https://gitea.com/gitea/tea/pulls/115 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #10960
Instead, set
GO111MODULE=offforxgoandgxzdownloads.