Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix document error about 'make trans-copy' #29710

Merged
merged 10 commits into from
Mar 14, 2024
Merged

Fix document error about 'make trans-copy' #29710

merged 10 commits into from
Mar 14, 2024

Conversation

dlintw
Copy link
Contributor

@dlintw dlintw commented Mar 11, 2024

Change document to 'make docs'

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 11, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 11, 2024
@dlintw dlintw force-pushed the bug-make-trans-copy branch from 35baf01 to a6e4e1e Compare March 11, 2024 02:47
@yp05327
Copy link
Contributor

yp05327 commented Mar 11, 2024

@lunny
Does this command still necessary?

@lunny
Copy link
Member

lunny commented Mar 11, 2024

Maybe they should be removed. Now the docs use docusaurus, and hugo has been dropped.

@lunny lunny closed this Mar 11, 2024
@lunny lunny reopened this Mar 11, 2024
delvh
delvh previously approved these changes Mar 11, 2024
View reviewed changes
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 11, 2024
@GiteaBot GiteaBot added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 11, 2024
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 14, 2024
techknowlogick
techknowlogick approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've

docs/content/development/hacking-on-gitea.en-us.md Outdated Show resolved Hide resolved
docs/content/development/hacking-on-gitea.zh-cn.md Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 14, 2024
@techknowlogick
Copy link
Member

I've removed the deprecated make target, as well as cleaned up additional text in the docs that are no longer relevant.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 14, 2024
@techknowlogick techknowlogick enabled auto-merge (squash) March 14, 2024 21:55
@techknowlogick techknowlogick added skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Mar 14, 2024
@techknowlogick
Copy link
Member

Thanks @dlintw!

@techknowlogick techknowlogick merged commit 607ed27 into go-gitea:main Mar 14, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Mar 14, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 14, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 15, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
9859580 
* giteaofficial/main:
  Update JS dependences (go-gitea#29797)
  Unify search boxes (go-gitea#29530)
  Fix document error about 'make trans-copy' (go-gitea#29710)
  Remove jQuery AJAX from the diff functions (go-gitea#29743)
  Fix Safari spinner rendering (go-gitea#29801)
  Remove jQuery AJAX from the `repo-issue.js` file (go-gitea#29776)
  Improve commit record's ui in comment list (go-gitea#26619)
  enable tailwind nesting (go-gitea#29746)
@yp05327
Copy link
Contributor

yp05327 commented Mar 15, 2024 •
edited
Loading

emmm, I'm afraid we cann't simply delete it or we need do some changes in gitea-docusaurus .
Because I notice that this script is being used, and the ci is broken now:
https://gitea.com/gitea/gitea-docusaurus/src/commit/4c86e2308012f6822ac3054e8074923334396aff/Makefile#L36
https://gitea.com/gitea/gitea-docusaurus/actions/runs/1228/jobs/0#jobstep-4-11

@techknowlogick
Copy link
Member

@yp05327 perhaps we should move that into the docs repo itself

@techknowlogick
Copy link
Member

@yp05327 I've created the following PR: https://gitea.com/gitea/gitea-docusaurus/pulls/118

@6543 6543 modified the milestones: 1.23.0, 1.22.0 Mar 16, 2024
@dlintw dlintw deleted the bug-make-trans-copy branch March 21, 2024 03:53
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

@delvh delvh delvh left review comments

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/docs modifies/internal size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
8 participants
@dlintw @yp05327 @lunny @techknowlogick @KN4CK3R @delvh @GiteaBot @6543