Remove jQuery AJAX from the diff functions #29743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed all jQuery AJAX calls and replaced with our fetch wrapper - Tested the review conversation comment, resolve, unresolve, show more files, and load diff functionality and it works as before Signed-off-by: Yarden Shoham <[email protected]>
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
yardenshoham
added
the
type/refactoring
silverwind
reviewed
Mar 12, 2024
delvh
approved these changes
Mar 12, 2024
Comment on lines
-191
to
-193
| }).fail(() => { | ||
| } catch (error) { | ||
| console.error('Error:', error); | ||
| } finally { | ||
| $target.removeClass('disabled'); | ||
| }); |
There was a problem hiding this comment.
Wait, fail?
Interesting, this code was even more wrong than expected…
GiteaBot
added
lgtm/need 1
silverwind
reviewed
Mar 12, 2024
silverwind
reviewed
Mar 12, 2024
Co-authored-by: silverwind <[email protected]>
lunny
reviewed
Mar 14, 2024
web_src/js/features/repo-diff.js
Outdated
Comment on lines
197
to
200
| if (!resp) { | ||
| $target.removeClass('disabled'); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (!resp) { | |
| $target.removeClass('disabled'); | |
| return; | |
| } |
There was a problem hiding this comment.
Maybe remove only $target.removeClass('disabled');? To not continue if resp is falsy
silverwind
approved these changes
Mar 14, 2024
GiteaBot
added
lgtm/done
yardenshoham
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 15, 2024
* giteaofficial/main: Update JS dependences (go-gitea#29797) Unify search boxes (go-gitea#29530) Fix document error about 'make trans-copy' (go-gitea#29710) Remove jQuery AJAX from the diff functions (go-gitea#29743) Fix Safari spinner rendering (go-gitea#29801) Remove jQuery AJAX from the `repo-issue.js` file (go-gitea#29776) Improve commit record's ui in comment list (go-gitea#26619) enable tailwind nesting (go-gitea#29746)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo using
fetchinstead of jQuery AJAX