Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestions for issues #32327

Merged
merged 15 commits into from
Oct 29, 2024
Merged

Suggestions for issues #32327

merged 15 commits into from
Oct 29, 2024

Conversation

anbraten
Copy link
Contributor

@anbraten anbraten commented Oct 23, 2024 •
edited
Loading

closes #16872

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 23, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 23, 2024
@github-actions github-actions bot added modifies/templates This PR modifies the template files modifies/frontend labels Oct 23, 2024
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 23, 2024
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 23, 2024
@anbraten anbraten marked this pull request as ready for review October 23, 2024 15:24
@anbraten anbraten requested a review from wxiaoguang October 23, 2024 15:24
lunny
lunny reviewed Oct 23, 2024
View reviewed changes
web_src/js/utils/match.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Oct 23, 2024
@anbraten anbraten requested a review from lunny October 23, 2024 21:55
lunny
lunny reviewed Oct 23, 2024
View reviewed changes
routers/web/web.go Outdated Show resolved Hide resolved
@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Oct 23, 2024
@lunny
Copy link
Member

lunny commented Oct 23, 2024

And it's better that the keyword is highlighted or bold on the menu

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 24, 2024
@wxiaoguang wxiaoguang added this to the 1.23.0 milestone Oct 24, 2024
@lunny
Copy link
Member

lunny commented Oct 24, 2024 •
edited
Loading

Looks like the menus will display only inputting #. When typing the keywords following #, the menus will disappear.

@lunny
Copy link
Member

lunny commented Oct 25, 2024

Looks like the menus will display only inputting #. When typing the keywords following #, the menus will disappear.

The problem is issue_indexer.SearchIssues will search title, content and comments. Is that what we want? Maybe we just want to search title? And then maybe just use the database like to do the search.

@wxiaoguang
Copy link
Contributor

Looks like the menus will display only inputting #. When typing the keywords following #, the menus will disappear.

The problem is issue_indexer.SearchIssues will search title, content and comments. Is that what we want? Maybe we just want to search title? And then maybe just use the database like to do the search.

Does it block? Or could it be fine tuned later?

@lunny
Copy link
Member

lunny commented Oct 28, 2024

Looks like the menus will display only inputting #. When typing the keywords following #, the menus will disappear.

The problem is issue_indexer.SearchIssues will search title, content and comments. Is that what we want? Maybe we just want to search title? And then maybe just use the database like to do the search.

Does it block? Or could it be fine tuned later?

Not block. Let's improve it later.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 28, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 29, 2024
@GiteaBot
Copy link
Collaborator

@anbraten please fix the merge conflicts. 🍵

@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 29, 2024
@lunny
Copy link
Member

lunny commented Oct 29, 2024

@anbraten Please resolve the conflicts.

@wxiaoguang wxiaoguang merged commit b7fb20e into go-gitea:main Oct 29, 2024
26 checks passed
silverwind added a commit to silverwind/gitea that referenced this pull request Oct 30, 2024
@silverwind
Merge remote-tracking branch 'origin/main' into types-4
5600f34 
* origin/main: (21 commits)
  Fix toAbsoluteLocaleDate and add more tests (go-gitea#32387)
  Respect UI.ExploreDefaultSort setting again (go-gitea#32357)
  Fix absolute-date (go-gitea#32375)
  Fix undefined errors on Activity page (go-gitea#32378)
  Add new [lfs_client].BATCH_SIZE and [server].LFS_MAX_BATCH_SIZE config settings. (go-gitea#32307)
  remove unused call to $.HeadRepo in view_title template (go-gitea#32317)
  Fix clean tmp dir (go-gitea#32360)
  Optimize branch protection rule loading (go-gitea#32280)
  Suggestions for issues (go-gitea#32327)
  Migrate vue components to setup (go-gitea#32329)
  Fix db engine (go-gitea#32351)
  Refactor the DB migration system slightly (go-gitea#32344)
  Fix broken image when editing comment with non-image attachments (go-gitea#32319)
  Fix disable 2fa bug (go-gitea#32320)
  Upgrade rollup to 4.24.0 (go-gitea#32312)
  Upgrade vue to 3.5.12 (go-gitea#32311)
  Make admins adhere to branch protection rules (go-gitea#32248)
  Prevent from submitting issue/comment on uploading (go-gitea#32263)
  Add warn log when deleting inactive users (go-gitea#32318)
  Add `DISABLE_ORGANIZATIONS_PAGE` and `DISABLE_CODE_PAGE` settings for explore pages and fix an issue related to user search (go-gitea#32288)
  ...
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 31, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
b594773 
* giteaofficial/main:
  Fix suggestions for issues (go-gitea#32380)
  refactor: remove redundant err declarations (go-gitea#32381)
  Fix the missing menu in organization project view page (go-gitea#32313)
  Fix toAbsoluteLocaleDate and add more tests (go-gitea#32387)
  Respect UI.ExploreDefaultSort setting again (go-gitea#32357)
  Fix absolute-date (go-gitea#32375)
  Fix undefined errors on Activity page (go-gitea#32378)
  Add new [lfs_client].BATCH_SIZE and [server].LFS_MAX_BATCH_SIZE config settings. (go-gitea#32307)
  remove unused call to $.HeadRepo in view_title template (go-gitea#32317)
  Fix clean tmp dir (go-gitea#32360)
  Optimize branch protection rule loading (go-gitea#32280)
  Suggestions for issues (go-gitea#32327)
  Migrate vue components to setup (go-gitea#32329)
@wxiaoguang wxiaoguang mentioned this pull request Jan 8, 2025
Closed
@wxiaoguang
Copy link
Contributor

FYI: need this fix: Fix issue suggestion bug #33389

@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/dependencies modifies/frontend modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

autocompletion / suggestion for # (reverence issues/pulls)
4 participants
@anbraten @lunny @wxiaoguang @GiteaBot