Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue suggestion bug #33389

Merged
merged 8 commits into from
Jan 26, 2025
Merged

Fix issue suggestion bug #33389

merged 8 commits into from
Jan 26, 2025
+51 −8

Conversation

wxiaoguang
Copy link
Contributor

Fix #33388

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 25, 2025
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 25, 2025
@wxiaoguang wxiaoguang marked this pull request as draft January 25, 2025 10:44
@wxiaoguang wxiaoguang force-pushed the fix-issue-suggestion branch from 70a8c8c to 901c285 Compare January 25, 2025 13:53
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 25, 2025
@wxiaoguang wxiaoguang force-pushed the fix-issue-suggestion branch from 901c285 to 23ac435 Compare January 25, 2025 13:53
@wxiaoguang wxiaoguang marked this pull request as ready for review January 25, 2025 13:54
@wxiaoguang wxiaoguang changed the title Fix issue suggestion debounce Fix issue suggestion bug Jan 25, 2025
@wxiaoguang wxiaoguang mentioned this pull request Jan 25, 2025
Closed
@wxiaoguang wxiaoguang added type/bug backport/v1.23 This PR should be backported to Gitea 1.23 labels Jan 25, 2025
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Jan 25, 2025
@wxiaoguang wxiaoguang mentioned this pull request Jan 25, 2025
Merged
@wxiaoguang wxiaoguang added backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! labels Jan 25, 2025
@wxiaoguang wxiaoguang mentioned this pull request Jan 25, 2025
Merged
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 26, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 26, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) January 26, 2025 13:03
@wxiaoguang wxiaoguang merged commit e663c4a into go-gitea:main Jan 26, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the fix-issue-suggestion branch January 26, 2025 13:15
@wxiaoguang
Copy link
Contributor Author

Backport: Fix issue suggestion bug #33391

@silverwind
Copy link
Member

FYI upstream type improvments: github/text-expander-element#72

wxiaoguang added a commit that referenced this pull request Jan 27, 2025
@wxiaoguang
Fix issue suggestion bug (#33389) (#33391)
c30f4f4 
Backport #33389
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.23 This PR should be backported to Gitea 1.23 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

Debounced issue suggestion request makes text-expander report JS promise error
4 participants
@wxiaoguang @silverwind @lunny @GiteaBot