Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start the watcher after handshake. fix #626 #627

Merged
merged 1 commit into from
Jul 3, 2017
Merged

start the watcher after handshake. fix #626 #627

merged 1 commit into from
Jul 3, 2017

Conversation

shogo82148
Copy link
Contributor

@shogo82148 shogo82148 commented Jun 28, 2017 •
edited
Loading

Description

start the watcher after handshake.
because mc.cleanup is not called when handshake fails.
fix #626

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@qw4990 qw4990 mentioned this pull request Jun 28, 2017
Closed
@julienschmidt julienschmidt merged commit bf7f34f into go-sql-driver:master Jul 3, 2017
@jsha jsha mentioned this pull request Nov 14, 2019
Closed
@shogo82148 shogo82148 deleted the fix-626 branch January 4, 2020 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienschmidt julienschmidt julienschmidt approved these changes

@methane methane methane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Goroutine leak when dial err in go1.8
3 participants
@shogo82148 @methane @julienschmidt