Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update github.com/go-sql-driver/mysql to latest tagged release #4530

Closed
cpu opened this issue Nov 6, 2019 · 3 comments · Fixed by #4552
Closed

Update github.com/go-sql-driver/mysql to latest tagged release #4530

cpu opened this issue Nov 6, 2019 · 3 comments · Fixed by #4552
Assignees
@jsha
Labels
area/libraries kind/update layer/storage
Milestone
Sprint 2019-11-12

Comments

@cpu
Copy link
Contributor

cpu commented Nov 6, 2019

Self-explanatory. We current use an explicit commit and should transition to v1.4.1
@jsha jsha added this to the Sprint 2019-11-12 milestone Nov 12, 2019
@jsha jsha self-assigned this Nov 12, 2019
@jsha
Copy link
Contributor

jsha commented Nov 14, 2019

Unfortunately v1.4.1 pulls in an unneeded dependency on google.golang.org/appengine. That dependency is removed in master. I've asked the maintainers to tag a new release.

@jsha
Copy link
Contributor

jsha commented Nov 14, 2019

Some interesting PRs we'll pick up with the upgrade:

Remove strict mode - go-sql-driver/mysql#676
context.Context support - go-sql-driver/mysql#608, go-sql-driver/mysql#612, go-sql-driver/mysql#627, go-sql-driver/mysql#761)

@cpu
Copy link
Contributor Author

cpu commented Nov 14, 2019

I've asked the maintainers to tag a new release.

It looks like that request was closed as a dupe of one open since April 2019 :-/ If we're likely to be blocked for months+ on a new tag maybe we should consider alternatives (pinning a revision, eating the unneeded dep?)

@jsha jsha mentioned this issue Nov 15, 2019
Merged
rolandshoemaker pushed a commit that referenced this issue Nov 15, 2019
@jsha @rolandshoemaker
Update mysql to b4242ba (latest). (#4552)
0804e97 
The most recent tagged release of mysql is v1.4.1, from a year ago. It
also happens to pull in an unwanted dependency (appengine) that the
latest commit does not.

Tests pass:

$ go test -count=1 github.com/go-sql-driver/mysql
ok github.com/go-sql-driver/mysql 0.068s

Fixes #4530
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsha jsha

Labels
area/libraries kind/update layer/storage
Projects
None yet
Milestone
Sprint 2019-11-12
Development

Successfully merging a pull request may close this issue.

Update mysql to b4242ba (latest). letsencrypt/boulder
2 participants
@jsha @cpu