Memory leaks / method invocation side effects. #422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! Thank you for the PR. As master branch is not ready for release yet, please rebase your PR on 2.x branch, so I will be able to release a quick patch. Also, there are some issues in review, please fix them before merging |
lisachenko
requested changes
Jul 31, 2019
| @@ -93,6 +93,11 @@ public function __construct(string $className, string $methodName, array $advice | |||
| if ($this->level > 0) { | |||
| [$this->arguments, $this->instance, $this->current] = array_pop($this->stackFrames); | |||
| } | |||
| else { | |||
There was a problem hiding this comment.
Put else on the previous line after figure bracket.
| else { | ||
| $this->arguments = []; | ||
| $this->instance = null; | ||
| $this->current = null; |
There was a problem hiding this comment.
Please, align all consecutive assignments. Also, $this->current is updated each time in the recursive calls, I'm not sure that your patch support recursive calls. I would suggest to drop this line entirely, clear only arguments and instance variables
|
Closing this in favor of #423 |
|
The inspection completed: No new issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for your awesome framework!
Unfortunately, a method \Go\Aop\Framework\AbstractMethodInvocation::__invoke doesn't free references to method arguments as soon as have been invoked which results in:
I hope my small pull request will help your cool project to become a bit better.
Thank you!