Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leaks / method invocation side effects 2.x #423

Merged
merged 1 commit into from
Aug 1, 2019

Conversation

badrutdinovrr
Copy link
Contributor

Continuation of the #422 with another base branch.
Changes:

  1. Consecutive assignments are aligned
  2. else is put on the same line as a closing bracket
  3. Removed current zero assignment.
    Thank you for your review!

@badrutdinovrr badrutdinovrr changed the title Fixes memory leaks / method invocation side effects. Memory leaks / method invocation side effects 2.x Jul 31, 2019
@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@lisachenko lisachenko added the Bug label Aug 1, 2019
@lisachenko lisachenko added this to the 2.3.2 milestone Aug 1, 2019
@lisachenko lisachenko merged commit 233f71c into goaop:2.x Aug 1, 2019
@lisachenko
Copy link
Member

Merged into 2.x, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants