Implement R/W Lock #493
Merged
Implement R/W Lock #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #493 +/- ##
==========================================
+ Coverage 83.33% 83.64% +0.31%
==========================================
Files 52 53 +1
Lines 9176 9308 +132
==========================================
+ Hits 7647 7786 +139
+ Misses 1291 1284 -7
Partials 238 238
Continue to review full report at Codecov.
|
64kramsystem
force-pushed
the
sm-implement_rw_mutex
branch
from
3fb0a39 to
c501cdb
Compare
ghost
added
the
|
@st0012 a couple of notes about this PR:
|
|
@st0012 do you have any insights about the build failure (link)? the tests I wrote pass when I execute them locally, but when running the full build, it seems go is detecting threading issues (is it the testing framework?): |
64kramsystem
force-pushed
the
sm-implement_rw_mutex
branch
from
c501cdb to
1e9752b
Compare
|
@saveriomiroddi Looks like it is because multiple threads want to check if there's error on the stack, but they all want to access the same stack (I guess it's the main stack) instead of their own stack. |
|
@st0012 I've opened an issue (#499); the minimal test case that triggers the error doesn't involve Concurrent::RWLock: so I suppose there's a problem either with the testing framework, or the interpreter. I definitely think that threading needs unit testing (especially since it's a selling point of Goby), also to find out if the testing framework is adequate, or needs to be improved. |
|
@saveriomiroddi This is what I'm concerning about. If there really are multiple threads running in a test case, the race condition will very likely to happen. So in this case, use race condition detector doesn't make sense. However, it'll be hard to find out some cases that race condition might cause nil pointer error. |
64kramsystem
force-pushed
the
sm-implement_rw_mutex
branch
6 times, most recently
from
08ad823 to
512a44f
Compare
64kramsystem
force-pushed
the
sm-implement_rw_mutex
branch
3 times, most recently
from
98d9577 to
c65cd83
Compare
64kramsystem
force-pushed
the
sm-implement_rw_mutex
branch
2 times, most recently
from
76c06a5 to
6b639ea
Compare
|
@st0012 The build tag strategy didn't work for filtering the tests to be performed without race detector (because untagged test suites are always run). I also had a fair amount of hair pulling because I didn't understand how the travis test (plugin) filtering was working - turns out, it was broken (see #518). |
64kramsystem
force-pushed
the
sm-implement_rw_mutex
branch
from
6b639ea to
2bbc8a8
Compare
|
Removed the |
64kramsystem
force-pushed
the
sm-implement_rw_mutex
branch
from
2bbc8a8 to
d49e6e9
Compare
st0012
approved these changes
Nov 22, 2017
|
ok, I've fixed the failures from the master merge; once the build is green, it's ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of Readers/writer lock.
In order to allow execution of some tests with race detector, this PR adds support for the
noracedetectiontag, and separates the test build into regular, andnoracedetection.Closes #477