Add float support to sleep() #498
Conversation
ghost
added
the
|
@st0012 I couldn't find any existing UT for this method, so I haven't added any (I'm not sure if there is a reason for it). |
Codecov Report
@@ Coverage Diff @@
## master #498 +/- ##
==========================================
- Coverage 83.45% 83.35% -0.11%
==========================================
Files 52 52
Lines 9123 9134 +11
==========================================
Hits 7614 7614
- Misses 1273 1284 +11
Partials 236 236
Continue to review full report at Codecov.
|
64kramsystem
force-pushed
the
sm-add_float_support_to_sleep
branch
from
cca4526 to
d077a16
Compare
|
@saveriomiroddi I'd merge this once the coverage issue is fixed |
|
👍 |
Also improved the error handling, that would otherwise panic when not receiving the expected data type.
64kramsystem
force-pushed
the
sm-add_float_support_to_sleep
branch
from
7ab3511 to
8ee02ad
Compare
|
@saveriomiroddi Can you take a look at this CI failure? I think it's because I clicked on update branch but I have no right to write your fork. |
vm/class.go
Outdated
| float, ok := args[0].(*FloatObject) | ||
|
|
||
| if ok { | ||
| nanoseconds := int64(float.value * 1000000000) |
There was a problem hiding this comment.
Can this number be set as a constant?
There was a problem hiding this comment.
Hmmm, there may be a more idiomatic way to express that. Hold on, I will check if I can improve it.
|
There you go, I've found a more expressive way for that statement. |
Add float support, and also improve the error handling.