Support Godot 3.4 #829
Merged
Support Godot 3.4 #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bromeon
added
feature
Bromeon
force-pushed
the
feature/godot-3.4
branch
from
74ac0a0 to
8185e2f
Compare
|
Merging, so other PRs can be tested against Godot 3.4. bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 15, 2021
829: Support Godot 3.4 r=Bromeon a=Bromeon Updates api.json, CI scripts and examples. This is a **breaking change**. Some GDNative APIs added default parameters, which can currently not be modeled in a backwards-compatible way in godot-rust (Rust itself doesn't support default parameters). It is however possible to manually generate `api.json` for an older Godot version (3.2 or 3.3) and keep using godot-rust normally. Addresses #814 in the short-term 🛠️ Still on the radar: #640 📡 Co-authored-by: Jan Haller <[email protected]>
Bromeon
force-pushed
the
feature/godot-3.4
branch
from
8185e2f to
bedcf91
Compare
|
Canceled. |
Bromeon
force-pushed
the
feature/godot-3.4
branch
from
bedcf91 to
5a0f24f
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates api.json, CI scripts and examples.
This is a breaking change. Some GDNative APIs added default parameters, which can currently not be modeled in a backwards-compatible way in godot-rust (Rust itself doesn't support default parameters). It is however possible to manually generate
api.jsonfor an older Godot version (3.2 or 3.3) and keep using godot-rust normally.Addresses #814 in the short-term 🛠️
Still on the radar: #640 📡